Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Literate all examples #63

Merged
merged 17 commits into from
Apr 26, 2020
Merged

Literate all examples #63

merged 17 commits into from
Apr 26, 2020

Conversation

navidcy
Copy link
Member

@navidcy navidcy commented Apr 25, 2020

No description provided.

@navidcy navidcy requested a review from glwagner April 25, 2020 22:21
@navidcy
Copy link
Member Author

navidcy commented Apr 25, 2020

Probably we should include some figures in the examples...

@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files           6        6           
  Lines         510      510           
=======================================
  Hits          503      503           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0a61d...417fcb8. Read the comment docs.

@navidcy
Copy link
Member Author

navidcy commented Apr 26, 2020

@glwagner, can you confirm that docs can be build properly? You should be able to build the docs simply by calling

julia --project=docs/ -e 'using Pkg; Pkg.instantiate(); Pkg.develop(PackageSpec(path=pwd()))'
julia --project=docs/ docs/make.jl

from the repo directory.

Here's a glimpse of what I get:

Screen Shot 2020-04-26 at 4 25 58 pm

Copy link
Member

@glwagner glwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like amazing progress.

@navidcy
Copy link
Member Author

navidcy commented Apr 26, 2020

@glwagner, wanna have another look before I merge? I pushed more examples..

@navidcy navidcy changed the title Literate TwoDNavierStokes examples Literate all examples Apr 26, 2020
@navidcy navidcy merged commit d3675b5 into master Apr 26, 2020
@navidcy navidcy deleted the LiterateDocs branch April 27, 2020 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants