Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn if we are overriding is= attribute #7

Open
lourot opened this issue Jun 6, 2023 · 0 comments
Open

Warn if we are overriding is= attribute #7

lourot opened this issue Jun 6, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@lourot
Copy link
Member

lourot commented Jun 6, 2023

When doing

<ImageDisplayControl>
  <img src=... />
</ImageDisplayControl>

an is="image-display-control" attribute will be added to the <img> tag in order to turn it into an Image Display Control web component. This is problematic however if the <img> tag already had another is= attribute, e.g.

<ImageDisplayControl>
  <img is="already-another-component" src=... />
</ImageDisplayControl>

An <img> tag can't be two web components at the same time. We should at least issue a warning if this happens.

@lourot lourot added the good first issue Good for newcomers label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant