Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static reference to yaml user backend. #20

Closed
SebastianOpriel opened this issue Oct 25, 2021 · 3 comments
Closed

Static reference to yaml user backend. #20

SebastianOpriel opened this issue Oct 25, 2021 · 3 comments
Assignees

Comments

@SebastianOpriel
Copy link

Shall

User.add_user(admin, 'yaml')

and
User.add_user(user, json['userBackend'] || 'yaml')

not be depending on omejdn.yml and user_backend variable instead of referencing statically to the user's yaml?

@SebastianOpriel
Copy link
Author

Same here:

User.add_user(user, 'yaml')

@bellebaum bellebaum self-assigned this Oct 25, 2021
@bellebaum
Copy link
Contributor

Yes, thank you :) I have been meaning to change this. PR will follow later today to allow specifying a default backend

bellebaum added a commit that referenced this issue Oct 25, 2021
A new configuration option was added to the base config to specify a default user backend

This addresses issue #20
@bellebaum bellebaum mentioned this issue Oct 25, 2021
bellebaum added a commit that referenced this issue Oct 27, 2021
* Fixed uninitialized variable
A leftover from past changes noticed thanks to issue #19

* Removed references to any particular configuration of user backends
A new configuration option was added to the base config to specify a default user backend

This addresses issue #20

* Adapt tests to altered configuration options

* Allowed scopes of clients are now checked when issuing tokens

* Reduced code duplications in tests

And fixed a bug where certain attributes were not updated via the admin API

* Write release notes
@bellebaum
Copy link
Contributor

This was changed in the current version. Closing.

bellebaum added a commit that referenced this issue Nov 2, 2021
* Fixed uninitialized variable
A leftover from past changes noticed thanks to issue #19

* Removed references to any particular configuration of user backends
A new configuration option was added to the base config to specify a default user backend

This addresses issue #20

* Adapt tests to altered configuration options

* Allowed scopes of clients are now checked when issuing tokens

* Reduced code duplications in tests

And fixed a bug where certain attributes were not updated via the admin API

* Write release notes

* Minor Bugfixes:
Replaced wrong occurences of 'token' with 'id_token'
Load webfinger conf through config.rb
Disable id_token creation when openid is set to false

* several ENV variables are now written to config files

This allows specifying them through the config files alone
and removes several bugs where ENV did not have an effect when it should

Includes some bugfixes:
- expected nil when checking the scopen in /token, got []
- logout redirect unconfigured

* This is a temporary mitigation for issue #18
It disables sinatra/cors and handles OPTION requests and Access-Control-Allow-* Headers manually

At some point we want to revisit this.

* One script - all tests
For convenience

* Adapted omejdn.yml

* Added requestable claim values

* Ensure ENV does not overwrite the config

* Added missing test for claims parameter in the authorization flow

* Update README

* Updated Release Notes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants