Dynamic claim values #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A leftover from past changes noticed thanks to issue #19
A new configuration option was added to the base config to specify a default user backend This addresses issue #20
And fixed a bug where certain attributes were not updated via the admin API
Replaced wrong occurences of 'token' with 'id_token' Load webfinger conf through config.rb Disable id_token creation when openid is set to false
This allows specifying them through the config files alone and removes several bugs where ENV did not have an effect when it should Includes some bugfixes: - expected nil when checking the scopen in /token, got [] - logout redirect unconfigured
It disables sinatra/cors and handles OPTION requests and Access-Control-Allow-* Headers manually At some point we want to revisit this.
For convenience
|
I will rework the README and merge then |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, next to several bugfixes,
adds the option to specify desired values for ID token claims.
This is standardized per OIC Core Spec, Section 5.5.
Additionally, we also support requesting claims for an access token in a similar matter when requesting said token.
This behaviour is not standardized, but follows this IETF draft.
Other changes:
Bugfixes:
tokenwithid_tokenopenidfunctionality is disabled