Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use channel closing rather than sending None explicitly #32

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

Dr-Emann
Copy link
Contributor

Rather than sending None when we want to close the channel, explicitly close the sending side with drop, which will automatically stop the iteration.

@Freaky Freaky merged commit 43ea3ba into Freaky:master Oct 15, 2020
@Freaky
Copy link
Owner

Freaky commented Oct 15, 2020

I can't remember why I didn't do this originally, I remember thinking about it, but I didn't get around to actually doing it. Evidently not the happiest block of code I've ever written.

Thanks!

@Dr-Emann Dr-Emann deleted the simplify_chan branch April 6, 2022 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants