-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[For v0.19]Backup files policy #1148
Conversation
3bd9f62
to
045547b
Compare
9528239
to
59ff253
Compare
7f816f5
to
11435ee
Compare
fdddc02
to
4e010ce
Compare
7741377
to
c869403
Compare
0b08580
to
60a976e
Compare
d00a3d8
to
87e06b8
Compare
6c14c7b
to
c310cdc
Compare
1 - Reports the error to the user in a popup. 2 - Names of the backups include the timstamp instead of a number. Names have more sense and the files can be sorted by names what is also the age order. 3 - Behaviors when changing configuration improved, the number of files present on the system was not reduced when reducing the number of backups or backups deactivated.
…archives. Saving is absolute priority.
the same start in the name (testCouleur.FCstd and testCouleur1.FCStd for example.
Initialization of the date format miss placement of the extra extension when conflict with names names
This PR is more than one year old and IIRC it was made to respond a google drive problem... Is it still an issue? Should we reconsider merging it? Honestly I'm a bit uneasy with it because it changes a lot of stuff in the file saving system which might potentially bring bugs... So close to the release it might be a bad idea, even more if it's not fixing anything critical. Or we reschedule it for 0.19? |
The PR proposes also a policy in the naming of the different archives.
It also makes the software resilient to file system issues (archive locked for whatever reason, un-ability to erase an archive, ...).
these 2 reasons are good enough to take the PR.
Google solved the problem obviously, and I did not encounter the problem since many month. But who can ensure other software do not introduce this kind of issues (dropbox, onedrive, anti-virus, ...)
It has been tested not only by me, and the change is quite well located in the code.
I am updating the PR just in case.
Do whatever you want!
|
I have been rebasing the PR may be 50 times until I gave up. The PR is 1 year and 4 month old.
Tell me if I make this effort the PR will be considered and will not wait an extra 1.5 years until next release, and again and again. Regards |
No need to put more effort into that. Most of the PR has become obsolete in the meantime anyway and for the part of the PR that can be integrated some refactoring work of FreeCAD must be done beforehand. There I plan to split the code for the backup creation to its own class so that it will be much easier to support different strategies. |
Merged. |
Thank you for creating a pull request to contribute to FreeCAD! To ease integration, please confirm the following:
git pull --rebase upstream master
./bin/FreeCAD --run-test 0
issue #<id>
orfixes #<id>
where<id>
is the associated MantisBT issue id if one existsAnd please remember to update the Wiki with the features added or changed once this PR is merged.
Improvement of saves:
See Forum :
https://forum.freecadweb.org/viewtopic.php?f=8&t=25601