Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material: Compatibility with older FCMat files #13339

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

davesrocketshop
Copy link
Contributor

Provides compatibility loading older files outside the context of a library.

Older material files were loaded by specifying a path. The new material system used the path to associated the material with a library, which may not be appropriate for legacy files. This change allows the use of materials outside of a library.

Additionally, legacy files often have name/value pairs not part of the standard list of properties. Since these were unable to be mapped to a model property they were ignored. Materials now maintain a legacy map to hold properties not associated with a property model. These properties are considered transient and will not be saved. It is not intended for this feature to be used as a generic container for properties not mapped to an appropriate model.

Fixes #13302

Provides compatibility loading older files outside the context of
a library.

Older material files were loaded by specifying a path. The new
material system used the path to associated the material with a
library, which may not be appropriate for legacy files. This change
allows the use of materials outside of a library.

Additionally, legacy files often have name/value pairs not part of the
standard list of properties. Since these were unable to be mapped to
a model property they were ignored. Materials now maintain a legacy
map to hold properties not associated with a property model. These
properties are considered transient and will not be saved. It is not
intended for this feature to be used as a generic container for
properties not mapped to an appropriate model.

Fixes FreeCAD#13302
@github-actions github-actions bot added the Mod: Materials Materials related label Apr 6, 2024
@yorikvanhavre yorikvanhavre merged commit f950a0c into FreeCAD:main Apr 15, 2024
10 checks passed
@davesrocketshop davesrocketshop deleted the issue_13302 branch May 14, 2024 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Materials Materials related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Materials: Unable to open an older material that is not part of a library
2 participants