Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIM: Fix BIM tutorial issues #14210

Merged
merged 1 commit into from
May 23, 2024

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented May 22, 2024

UI file is now in a resources file.
Translate function was not defined.

Forum topic:
https://forum.freecad.org/viewtopic.php?t=87830

UI file is now in a resources file.
Translate function was not defined.

Forum topic:
https://forum.freecad.org/viewtopic.php?t=87830
@Roy-043 Roy-043 added the Mod: BIM Related to the BIM/Arch Workbench label May 22, 2024
@Roy-043
Copy link
Contributor Author

Roy-043 commented May 22, 2024

It may be wise to check other occurrences of
os.path.join(os.path.dirname(__file__)
in the code.

@yorikvanhavre
Copy link
Member

yorikvanhavre commented May 22, 2024

Thanks! Wow, good call... I thought I had them all but there are still many 😅

grep -r "os.path.join(os.path.dirname(__file__)" *
ArchProfile.py:                os.path.join(os.path.dirname(__file__),"Presets","profiles.csv"),
bimcommands/__init__.py:modules = glob.glob(os.path.join(os.path.dirname(__file__), "*.py"))
bimcommands/BimProjectManager.py:    humanpath = os.path.join(os.path.dirname(__file__), "geometry", "human figure.brep")
bimcommands/BimPreflight.py:                    os.path.join(os.path.dirname(__file__), "dialogPreflightResults.ui")
bimcommands/BimTrash.py:            "Pixmap": os.path.join(os.path.dirname(__file__), "icons", "BIM_Trash.svg"),
bimcommands/BimLibrary.py:                os.path.join(os.path.dirname(__file__), "icons", "BIM_Library.svg")
bimcommands/BimLibrary.py:                        os.path.join(os.path.dirname(__file__), "icons", "IFC.svg")
bimcommands/BimMaterial.py:                    os.path.join(os.path.dirname(__file__), "dialogListWidget.ui")
bimcommands/BimTutorial.py:                os.path.join(os.path.dirname(__file__), "dialogTutorial.ui")
BimStatusBar.py:                os.path.join(os.path.dirname(__file__), "dialogNudgeValue.ui")
nativeifc/ifc_preferences.py:    page = os.path.join(os.path.dirname(__file__), "ui", "preferencesNativeIFC.ui")

Will do them ASAP

yorikvanhavre added a commit to yorikvanhavre/FreeCAD that referenced this pull request May 23, 2024
@yorikvanhavre yorikvanhavre merged commit d90a783 into FreeCAD:main May 23, 2024
10 checks passed
@Roy-043 Roy-043 deleted the BIM-Fix-BIM-tutorial-issues branch May 24, 2024 14:21
chennes pushed a commit that referenced this pull request May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: BIM Related to the BIM/Arch Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants