Arch: Fix Site, Building, Floor objects creation #210
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-New param : GetBool("FreeLinking",False), unavailable in pref see
parameters
-by default :
allow create Site on Building only
deny create Building on Site or Building
deny create Floor on Site, Building,Floor
-option:
allow create and linking what you want (until non-DAG)
|
The messages that gets popped up should be prepared for translation. |
|
Indeed, I will fix that asap. Btw is there a global system for popup in FreeCAD ? Like FreeCAD.Console.PrintMessage but with a window ? |
|
No, if you want to pop up a message you should explicitly use a QMessageBox. |
|
@wood-galaxy should we wait for you to add translation to the messages? Also, IFC allows to have floors inside floors. Maybe we should too... |
|
@yorikvanhavre I'm on it : translation and floors in floor. |
|
merged! |
ppd
pushed a commit
to ppd/FreeCAD
that referenced
this pull request
Jan 17, 2022
ipatch
pushed a commit
to ipatch/FreeCAD
that referenced
this pull request
Mar 26, 2022
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-New param : GetBool("FreeLinking",False), unavailable in pref see
parameters
-by default :
allow create Site on Building only
deny create Building on Site or Building
deny create Floor on Site, Building,Floor
-option:
allow create and linking what you want (until non-DAG)