Draft: re-organization of the trackers code #3092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 21, 2020
vocx-fc
force-pushed
the
Draft_trackers
branch
2 times, most recently
from
83c1a8e
to
c560f6e
Compare
4 tasks
vocx-fc
force-pushed
the
Draft_trackers
branch
3 times, most recently
from
6eee207
to
f492f60
Compare
|
needs conflict solving |
Properly import the tracker classes. Avoid star imports, and use the classes prefixed with the name of the module. The BIM Workbench also has to be updated to use the new module. ``` import draftguitools.gui_trackers as DraftTrackers ```
Also change the imports in `DraftFillet.py` and `DraftEdit.py` so the trackers are found.
This was referenced Mar 23, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various tasks regarding the tracker commands.
gui_trackers.DraftTools.py, and we avoid star imports.trackers.PlaneTracker().Snapper,DraftFillet, andDraftEdit.This pull request needs to be merged after #3091 is merged so that the new files are correctly included in the variables in
CMakeLists.txt. When this happens, this request will create a conflict, so this pull request will have to be rebased onto the master branch, and then it will be able to be merged.Forum thread: [Discussion] Splitting Draft tools into their own modules.
The BIM Workbench needs to be changed as well to support the new tracker module, and then it can be used normally.
See yorikvanhavre/BIM_Workbench#38
git pull --rebase upstream master./bin/FreeCAD --run-test 0issue #<id>orfixes #<id>where<id>is the associated MantisBT issue id if one exists