Draft, Arch: import functions from utilities #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vocx-fc
force-pushed
the
Draft_Tools_utils
branch
2 times, most recently
from
c7fae6a
to
1a12377
Compare
4 tasks
vocx-fc
force-pushed
the
Draft_Tools_utils
branch
4 times, most recently
from
cd70c73
to
acd1f8d
Compare
Properly import the tracker classes. Avoid star imports, and use the classes prefixed with the name of the module. The BIM Workbench also has to be updated to use the new module. ``` import draftguitools.gui_trackers as DraftTrackers ```
Also change the imports in `DraftFillet.py` and `DraftEdit.py` so the trackers are found.
These functions were moved from DraftGui to individual modules precisely to make them easy to import. Otherwise we have to import the entire DraftGui module which creates dependency problems when we want to use some functions without the graphical interface.
These functions were moved from DraftTools and DraftGui to individual modules precisely to make them easy to import. Otherwise we have to import the entire DraftTools and DraftGui modules which creates dependency problems when we want to use some functions without the graphical interface.
vocx-fc
force-pushed
the
Draft_Tools_utils
branch
from
acd1f8d
to
ec9555a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of importing certain tools from
DraftToolsandDraftGui, we import them from the new utility modules,draftutils.todo,draftutils.translate, anddraftutils.utils.This is done both in Draft and Arch.
This pull request needs to be merged after #3092 is merged so that the previous patches apply cleanly. When this happens, this request will create a conflict, so this pull request will have to be rebased onto the master branch, and then it will be able to be merged.
Forum thread: [Discussion] Splitting Draft tools into their own modules.
git pull --rebase upstream master./bin/FreeCAD --run-test 0issue #<id>orfixes #<id>where<id>is the associated MantisBT issue id if one exists