Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Eliminate required GUI for importDXF #4661

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

chennes
Copy link
Member

@chennes chennes commented Mar 24, 2021

Bug reported by forums member tarrox -- the importDXF code assumes the existence of the GUI, but does not actually need it (a FreeCAD.GuiUp check suffices to protect the one line of code that was using the view provider).


Copy link
Contributor

@hyarion hyarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a variable gui = FreeCAD.GuiUp in this file that could be used instead but that doesn't seem to be consistently used.
I wouldn't mind if it was cleaned up and only one way was used, but either way I think this PR is ok to be merged.

@yorikvanhavre
Copy link
Member

this gui = FreeCAD.GuiUp is probably a leftover from some earlier structure... In any case indeed this should totally work without the GUI. Thanks for the fix!

@yorikvanhavre yorikvanhavre merged commit 43c23de into FreeCAD:master Mar 26, 2021
@chennes chennes deleted the draftImportDXFNoGUI branch March 27, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants