Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Fix near snap (issue #6613) #7132

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

Roy-043
Copy link
Contributor

@Roy-043 Roy-043 commented Jul 4, 2022

This PR fixes the inaccuracy of Draft Snap Near.

Forum topic:
https://forum.freecadweb.org/viewtopic.php?f=23&t=67289

Issue:
#6613

Additionally:

  • Snap Perpendicular now also works for faces.
  • Snap Perpendicular can now find multiple points. For example two points on a circular edge.
  • For clarity the snapToFace function was renamed to snapToCenterFace.
  • To snap to a vertex (f.e. a Draft Point) Snap Endpoint must now be used. This makes more sense IMO and is also consistent with snapping to points in a point cloud.
  • Your pull request is confined strictly to a single module. That is, all the files changed by your pull request are either in App, Base, Gui or one of the Mod subfolders. If you need to make changes in several locations, make several pull requests and wait for the first one to be merged before submitting the next ones
  • In case your pull request does more than just fixing small bugs, make sure you discussed your ideas with other developers on the FreeCAD forum
  • Your branch is rebased on latest master git pull --rebase upstream master
  • All FreeCAD unit tests are confirmed to pass by running ./bin/FreeCAD --run-test 0
  • All commit messages are well-written ex: Fixes typo in Draft Move command text
  • Your pull request is well written and has a good description, and its title starts with the module name, ex: Draft: Fixed typos
  • Commit messages include issue #<id> or fixes #<id> where <id> is the issue ID number from our Issues database in case a particular commit solves or is related to an existing issue. Ex: Draft: fix typos - fixes #4805

@github-actions github-actions bot added the Mod: Draft Related to the Draft Workbench label Jul 4, 2022
@yorikvanhavre
Copy link
Member

I wonder if snapping a face, near the edge, with near snap activated, shouldn't snap to the nearest edge instead... But that's just a thought for later..

@Roy-043
Copy link
Contributor Author

Roy-043 commented Jul 4, 2022

It is possible to snap to the edge of a face by just making sure it is highlighted. In rare cases the user may need to change the DrawStyle, although using Wireframe can be confusing in a crowded scene.

@Roy-043
Copy link
Contributor Author

Roy-043 commented Jul 4, 2022

As already mentioned here:
https://forum.freecadweb.org/viewtopic.php?p=607548#p607548

The code related to oldActive must be removed.

@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7132. Pipeline 579744256 was triggered at e6e2104. All CI branches and pipelines.

@yorikvanhavre
Copy link
Member

Okay just tested, alll works fine and it seems like the problem is solved! Thanks @Roy-043 !

@yorikvanhavre
Copy link
Member

(BTW you can write "issue #XXXX" in your commit message to auto relate it to an issue, or "fixes #XXXX" to autoclose related issues)

@Roy-043 Roy-043 deleted the Draft-Fix-near-snap branch July 5, 2022 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mod: Draft Related to the Draft Workbench
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants