Add intermediate solution to Algorithm-Roman-Numeral-Converter #1151
Conversation
ghost
self-assigned this
| @@ -68,6 +68,70 @@ convertToRoman(36); | |||
| - [For Loops](JS-For-Loop) | |||
| - [While Loops](JS-while-Loop) | |||
|
|
|||
| ## :intermediate: Intermediate Code Solution: | |||
|
Please add a section to our articles related to your solution. |
Rafase282
changed the title
|
I'm afraid I'm not sure what you want. I thought I was editing the existing On Thu, Jun 16, 2016 at 12:18 PM, Rafael J. Rodriguez <
|
|
Please take a look here #1094 We have a template for solutions, and you adding a new one also requires a section with related links. I was asking to add it and use links form our wiki if possible. Sorry for not being clear before. |
- Add links after both code explanations - Add a sunflower image in front of "Intermediate Code Solution" - Clean up code in Intermediate Code Solution - Add "@mrthnmn" to credits
|
|
||
| - [Roman Numerals](http://www.mathsisfun.com/roman-numerals.html) | ||
| - [Array.splice()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/splice) | ||
| - Array.indexOf()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf) |
There was a problem hiding this comment.
Array.indexOf()][Array.indexOf()]
Change this so it links to our internal article: JS-Array-Prototype-IndexOf.
|
Please try to fix the conflicts on your branch. Feel free to come to the wiki chat if you need help. |
|
|
||
| - [Roman Numerals](http://www.mathsisfun.com/roman-numerals.html) | ||
| - [Array.splice()](https://github.com/FreeCodeCamp/wiki/blob/master/JS-Array-Prototype-Splice.md) | ||
| - Array.indexOf()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf) |
There was a problem hiding this comment.
-- Array.indexOf()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf)
+- [Array.indexOf()](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/indexOf)
| - [For Loops](JS-For-Loop) | ||
| - [While Loops](JS-while-Loop) | ||
| - [For Loops](https://github.com/FreeCodeCamp/wiki/blob/master/JS-For-Loop.md) | ||
| - [While Loops](https://github.com/FreeCodeCamp/wiki/blob/master/JS-While-Loop.md) |
There was a problem hiding this comment.
-- [While Loops](https://github.com/FreeCodeCamp/wiki/blob/master/JS-While-Loop.md)
+- [While Loops](JS-While-Loop)
|
@mrthnmn, please resolve merge conflicts and implement suggestions 😉 |
|
I will do on Monday. I wasn't able to on Saturday because I was behind a On Sat, Jun 18, 2016 at 2:27 PM, Jonathan notifications@github.com wrote:
|
|
@mrthnmn this branch has conflicts. You might need to rebase the branch. |
|
Attempt to resolve conflicts |
A second (intermediate) solution has been added.