Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT removing unused internal functions and bundled dependencies #174

Merged
merged 7 commits into from
Sep 30, 2017
Merged

MAINT removing unused internal functions and bundled dependencies #174

merged 7 commits into from
Sep 30, 2017

Conversation

rth
Copy link
Contributor

@rth rth commented Sep 30, 2017 •
edited
Loading

This PR,

  • removes the bundled version of pathlib (+ scandir dependency) that was previously necessary for python 2.7
  • sets minimum requirements to scikit-learn 0.19 which allows removing the bundled 0.19->0.18 scikit-learn backports.
  • removes a few other deprecated internal helper functions.

Also fixes #170.

@rth rth added the deployment label Sep 30, 2017
@rth rth force-pushed the maint-dependencies branch 2 times, most recently from 7b38470 to cdbb085 Compare September 30, 2017 12:17
@rth rth merged commit fd220cb into FreeDiscovery:master Sep 30, 2017
@rth rth deleted the maint-dependencies branch September 30, 2017 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing check_estimator test and sphinx documentation generation
1 participant
@rth