Skip to content

Commit

Permalink
Keyboard capture changes, #1087 #1096 #1111
Browse files Browse the repository at this point in the history
  • Loading branch information
@giox069
giox069 committed Feb 11, 2017
1 parent 3df2d8e commit 7bfb2a5
Showing 1 changed file with 87 additions and 36 deletions.
123 changes: 87 additions & 36 deletions remmina/src/remmina_connection_window.c
View file
Expand Up @@ -116,6 +116,9 @@ G_DEFINE_TYPE( RemminaConnectionWindow, remmina_connection_window, GTK_TYPE_WIND

gint view_mode;

gboolean kbcaptured;
gboolean mouse_pointer_entered;

};

typedef struct _RemminaConnectionObject
Expand Down Expand Up @@ -292,10 +295,9 @@ static void remmina_connection_holder_disconnect_current_page(RemminaConnectionH
remmina_protocol_widget_close_connection(REMMINA_PROTOCOL_WIDGET(cnnobj->proto));
}

static void remmina_connection_holder_keyboard_grab(RemminaConnectionHolder* cnnhld)
static void remmina_connection_holder_keyboard_ungrab(RemminaConnectionHolder* cnnhld)
{
TRACE_CALL("remmina_connection_holder_keyboard_grab");
DECLARE_CNNOBJ
TRACE_CALL("remmina_connection_holder_keyboard_ungrab");
GdkDisplay *display;
GdkDeviceManager *manager;
GdkDevice *keyboard = NULL;
Expand All @@ -304,45 +306,71 @@ static void remmina_connection_holder_keyboard_grab(RemminaConnectionHolder* cnn
manager = gdk_display_get_device_manager(display);
keyboard = gdk_device_manager_get_client_pointer(manager);

if (keyboard != NULL)
if (!cnnhld->cnnwin->priv->kbcaptured)
{
return;
}

if ( gdk_device_get_source (keyboard) != GDK_SOURCE_KEYBOARD)
if (keyboard != NULL)
{
if ( gdk_device_get_source(keyboard) != GDK_SOURCE_KEYBOARD )
{
keyboard = gdk_device_get_associated_device( keyboard );
keyboard = gdk_device_get_associated_device(keyboard);
}

if (remmina_file_get_int(cnnobj->remmina_file, "keyboard_grab", FALSE))
{
gdk_device_grab(keyboard, gtk_widget_get_window(GTK_WIDGET(cnnhld->cnnwin)), GDK_OWNERSHIP_WINDOW, TRUE, GDK_KEY_PRESS | GDK_KEY_RELEASE, NULL, GDK_CURRENT_TIME);
}
else
{
gdk_device_ungrab(keyboard, GDK_CURRENT_TIME);
}
#if GTK_CHECK_VERSION(3, 20, 0)
gdk_seat_ungrab(gdk_device_get_seat(keyboard));
#else
gdk_device_ungrab(keyboard, GDK_CURRENT_TIME);
#endif
cnnhld->cnnwin->priv->kbcaptured = FALSE;

}
}

static void remmina_connection_holder_keyboard_ungrab(RemminaConnectionHolder* cnnhld)
static void remmina_connection_holder_keyboard_grab(RemminaConnectionHolder* cnnhld)
{
TRACE_CALL("remmina_connection_holder_keyboard_ungrab");
TRACE_CALL("remmina_connection_holder_keyboard_grab");
DECLARE_CNNOBJ
GdkDisplay *display;
GdkDeviceManager *manager;
GdkDevice *keyboard = NULL;

if (cnnhld->cnnwin->priv->kbcaptured)
{
return;
}

display = gtk_widget_get_display(GTK_WIDGET(cnnhld->cnnwin));
manager = gdk_display_get_device_manager(display);
keyboard = gdk_device_manager_get_client_pointer(manager);

if (keyboard != NULL)
{
if ( gdk_device_get_source(keyboard) != GDK_SOURCE_KEYBOARD )

if ( gdk_device_get_source (keyboard) != GDK_SOURCE_KEYBOARD)
{
keyboard = gdk_device_get_associated_device(keyboard);
keyboard = gdk_device_get_associated_device( keyboard );
}
gdk_device_ungrab(keyboard, GDK_CURRENT_TIME);
}

if (remmina_file_get_int(cnnobj->remmina_file, "keyboard_grab", FALSE))
{
#if GTK_CHECK_VERSION(3, 20, 0)
if (gdk_seat_grab(gdk_device_get_seat(keyboard), gtk_widget_get_window(GTK_WIDGET(cnnhld->cnnwin)),
GDK_SEAT_CAPABILITY_ALL, FALSE, NULL, NULL, NULL, NULL) == GDK_GRAB_SUCCESS)
#else
if (gdk_device_grab(keyboard, gtk_widget_get_window(GTK_WIDGET(cnnhld->cnnwin)), GDK_OWNERSHIP_WINDOW,
TRUE, GDK_KEY_PRESS | GDK_KEY_RELEASE, NULL, GDK_CURRENT_TIME) == GDK_GRAB_SUCCESS)
#endif
{
cnnhld->cnnwin->priv->kbcaptured = TRUE;
}
}
else
{
remmina_connection_holder_keyboard_ungrab(cnnhld);
}
}
}

static void remmina_connection_window_close_all_connections(RemminaConnectionWindow* cnnwin)
Expand Down Expand Up @@ -414,6 +442,9 @@ static void remmina_connection_window_destroy(GtkWidget* widget, RemminaConnecti
TRACE_CALL("remmina_connection_window_destroy");
RemminaConnectionWindowPriv* priv = REMMINA_CONNECTION_WINDOW(widget)->priv;

if (priv->kbcaptured)
remmina_connection_holder_keyboard_ungrab(cnnhld);

if (priv->floating_toolbar_motion_handler)
{
g_source_remove(priv->floating_toolbar_motion_handler);
Expand Down Expand Up @@ -1710,10 +1741,14 @@ static void remmina_connection_holder_toolbar_grab(GtkWidget* widget, RemminaCon
{
TRACE_CALL("remmina_connection_holder_toolbar_grab");
DECLARE_CNNOBJ
gboolean capture;

remmina_file_set_int(cnnobj->remmina_file, "keyboard_grab",
gtk_toggle_tool_button_get_active(GTK_TOGGLE_TOOL_BUTTON(widget)));
remmina_connection_holder_keyboard_grab(cnnhld);
capture = gtk_toggle_tool_button_get_active(GTK_TOGGLE_TOOL_BUTTON(widget));
remmina_file_set_int(cnnobj->remmina_file, "keyboard_grab", capture);
if (capture)
remmina_connection_holder_keyboard_grab(cnnhld);
else
remmina_connection_holder_keyboard_ungrab(cnnhld);
}

static GtkWidget*
Expand Down Expand Up @@ -2021,6 +2056,7 @@ static gboolean remmina_connection_object_enter_protocol_widget(GtkWidget* widge
static void remmina_connection_window_focus_in(GtkWidget* widget, RemminaConnectionHolder* cnnhld)
{
TRACE_CALL("remmina_connection_window_focus_in");

#if !FLOATING_TOOLBAR_WIDGET
RemminaConnectionWindowPriv* priv = cnnhld->cnnwin->priv;

Expand All @@ -2029,13 +2065,16 @@ static void remmina_connection_window_focus_in(GtkWidget* widget, RemminaConnect
remmina_connection_holder_floating_toolbar_visible(cnnhld, TRUE);
}
#endif
remmina_connection_holder_keyboard_grab(cnnhld);

if (cnnhld->cnnwin->priv->mouse_pointer_entered)
remmina_connection_holder_keyboard_grab(cnnhld);
}

static void remmina_connection_window_focus_out(GtkWidget* widget, RemminaConnectionHolder* cnnhld)
{
TRACE_CALL("remmina_connection_window_focus_out");
DECLARE_CNNOBJ

#if !FLOATING_TOOLBAR_WIDGET
RemminaConnectionWindowPriv* priv = cnnhld->cnnwin->priv;
#endif
Expand All @@ -2058,30 +2097,38 @@ static void remmina_connection_window_focus_out(GtkWidget* widget, RemminaConnec

}

static gboolean remmina_connection_window_focus_out_event(GtkWidget* widget, GdkEvent* event, RemminaConnectionHolder* cnnhld)
{
TRACE_CALL("remmina_connection_window_focus_out_event");
remmina_connection_holder_keyboard_ungrab(cnnhld);
return FALSE;
}

static gboolean remmina_connection_window_focus_in_event(GtkWidget* widget, GdkEvent* event, RemminaConnectionHolder* cnnhld)
{
TRACE_CALL("remmina_connection_window_focus_in_event");
if (cnnhld->cnnwin->priv->mouse_pointer_entered)
remmina_connection_holder_keyboard_grab(cnnhld);
return FALSE;
}

static gboolean remmina_connection_window_on_enter(GtkWidget* widget, GdkEventCrossing* event, RemminaConnectionHolder* cnnhld)
{
TRACE_CALL("remmina_connection_window_on_enter");
/*
if (event->detail == GDK_NOTIFY_VIRTUAL || event->detail == GDK_NOTIFY_NONLINEAR
|| event->detail == GDK_NOTIFY_NONLINEAR_VIRTUAL)
cnnhld->cnnwin->priv->mouse_pointer_entered = TRUE;
if (gtk_window_is_active(GTK_WINDOW(cnnhld->cnnwin)))
{
remmina_connection_holder_keyboard_grab(cnnhld);
}
*/
return FALSE;
}


static gboolean remmina_connection_window_on_leave(GtkWidget* widget, GdkEventCrossing* event, RemminaConnectionHolder* cnnhld)
{
TRACE_CALL("remmina_connection_window_on_leave");
/*
if (event->detail == GDK_NOTIFY_VIRTUAL || event->detail == GDK_NOTIFY_NONLINEAR
|| event->detail == GDK_NOTIFY_NONLINEAR_VIRTUAL)
{
remmina_connection_holder_keyboard_ungrab(cnnhld);
}
*/
cnnhld->cnnwin->priv->mouse_pointer_entered = FALSE;
remmina_connection_holder_keyboard_ungrab(cnnhld);
return FALSE;
}

Expand Down Expand Up @@ -2345,6 +2392,8 @@ static void remmina_connection_window_init(RemminaConnectionWindow* cnnwin)

priv->view_mode = AUTO_MODE;
priv->floating_toolbar_opacity = 1.0;
priv->kbcaptured = FALSE;
priv->mouse_pointer_entered = FALSE;

gtk_container_set_border_width(GTK_CONTAINER(cnnwin), 0);

Expand Down Expand Up @@ -2397,6 +2446,9 @@ remmina_connection_window_new_from_holder(RemminaConnectionHolder* cnnhld)
* via gdk_device_grab. So we listen for window-state-event to detect focus in and focus out */
g_signal_connect(G_OBJECT(cnnwin), "window-state-event", G_CALLBACK(remmina_connection_window_state_event), cnnhld);

g_signal_connect(G_OBJECT(cnnwin), "focus-in-event", G_CALLBACK(remmina_connection_window_focus_in_event), cnnhld);
g_signal_connect(G_OBJECT(cnnwin), "focus-out-event", G_CALLBACK(remmina_connection_window_focus_out_event), cnnhld);

g_signal_connect(G_OBJECT(cnnwin), "enter-notify-event", G_CALLBACK(remmina_connection_window_on_enter), cnnhld);
g_signal_connect(G_OBJECT(cnnwin), "leave-notify-event", G_CALLBACK(remmina_connection_window_on_leave), cnnhld);

Expand Down Expand Up @@ -3638,4 +3690,3 @@ remmina_connection_window_open_from_file_full(RemminaFile* remminafile, GCallbac
return protocolwidget;

}

0 comments on commit 7bfb2a5

Please sign in to comment.