Ssh improvements

[antenore]

This PR fixes some general issues, introduces some improvements and fixes the following issues:

• #708 the checkbox, 'Save SSH Password', grayed out.
• #1078 SSH password can't save , terminal auto disconnection
• #1187 "Public Key (Automatic)" option does not work with ed25519 keys

Some enhancements require libssh 0.7.X, i.e the support for ed25519 keys

[FossPrime]

I'll check this out later today, Thanks!

UPDATE: I took a look at the code, seems like it's missing ecdsa, gcloud's default root key

ssh-keygen -t ecdsa
Generating public/private ecdsa key pair.
Enter file in which to save the key (/home/username/.ssh/id_ecdsa): 

[FossPrime]

Built on Fedora 26 beta 1, using https://github.com/FreeRDP/Remmina/wiki/Compile-on-Fedora-20 only had to install rpmfusion free, as ffmpeg-devel does not exist

sudo dnf install https://download1.rpmfusion.org/free/fedora/rpmfusion-free-release-$(rpm -E %fedora).noarch.rpm

tested on a vanilla fedora 26. connecting with RDP through an ssh tunnel that only accepts ed25519 and it worked, both with the SSH agent (automatic) and public key (automatic). I was connecting to a windows 7 machine. There were a few warnings...

[xxxx@localhost-live Remmina]$ remmina
StatusNotifier/Appindicator support: not supported by desktop. libappindicator will try to fallback to GtkStatusIcon/xembed

(remmina:3410): Gtk-WARNING **: gtk_menu_attach_to_widget(): menu already attached to GtkMenuItem

(remmina:3410): Gdk-CRITICAL **: gdk_window_thaw_toplevel_updates: assertion 'window->update_and_descendants_freeze_count > 0' failed
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
[09:43:26:553] [3410:3588] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[09:43:26:982] [3410:3588] [INFO][com.freerdp.crypto] - creating directory /home/xxxx/.config/freerdp
[09:43:26:982] [3410:3588] [INFO][com.freerdp.crypto] - creating directory [/home/xxxx/.config/freerdp/certs]
[09:43:26:982] [3410:3588] [INFO][com.freerdp.crypto] - created directory [/home/xxxx/.config/freerdp/server]
[09:43:27:660] [3410:3588] [ERROR][com.freerdp.crypto] - @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[09:43:27:660] [3410:3588] [ERROR][com.freerdp.crypto] - @           WARNING: CERTIFICATE NAME MISMATCH!           @
[09:43:27:660] [3410:3588] [ERROR][com.freerdp.crypto] - @@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@@
[09:43:27:660] [3410:3588] [ERROR][com.freerdp.crypto] - The hostname used for this connection (10.0.1.229:4732) 
[09:43:27:660] [3410:3588] [ERROR][com.freerdp.crypto] - does not match the name given in the certificate:
[09:43:27:660] [3410:3588] [ERROR][com.freerdp.crypto] - Common Name (CN):
[09:43:27:660] [3410:3588] [ERROR][com.freerdp.crypto] - 	WKS17
[09:43:27:660] [3410:3588] [ERROR][com.freerdp.crypto] - A valid certificate for the wrong name should NOT be trusted!
[09:43:31:524] [3410:3588] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRA32
[09:43:31:524] [3410:3588] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_RGB8

(remmina:3410): Gtk-WARNING **: Theme parsing error: <data>:16:28: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version

(remmina:3410): Gtk-WARNING **: Theme parsing error: <data>:17:31: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version

(remmina:3410): Gtk-WARNING **: Theme parsing error: <data>:22:28: The style property GtkWidget:focus-padding is deprecated and shouldn't be used anymore. It will be removed in a future version

(remmina:3410): Gtk-WARNING **: Theme parsing error: <data>:23:31: The style property GtkWidget:focus-line-width is deprecated and shouldn't be used anymore. It will be removed in a future version

(remmina:3410): Gdk-CRITICAL **: gdk_window_get_device_position_double: assertion 'GDK_IS_WINDOW (window)' failed
Gtk-Message: GtkDialog mapped without a transient parent. This is discouraged.
[09:44:02:022] [3410:3607] [INFO][com.freerdp.client.common.cmdline] - loading channelEx cliprdr
[09:44:04:484] [3410:3607] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_BGRA32
[09:44:04:484] [3410:3607] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_RGB8

[FossPrime]

runs great on fedora 26

[antenore]

@rayfoss thanks for your comments and for having updated the wiki!!!!