-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix build for supported targets #57
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbartell
force-pushed
the
add-build-workflow
branch
4 times, most recently
from
November 21, 2023 22:46
2b0a419
to
cfbf64c
Compare
Split builds into a separate GitHub workflow. Build for all supported targets with multiple esp-idf versions.
paulbartell
force-pushed
the
add-build-workflow
branch
from
November 23, 2023 18:00
cfbf64c
to
1f0e322
Compare
n9wxu
previously approved these changes
Dec 14, 2023
AniruddhaKanhere
previously approved these changes
Dec 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with one minor comment about missing new line at EOF.
archigup
previously approved these changes
Dec 14, 2023
paulbartell
dismissed stale reviews from archigup, AniruddhaKanhere, and n9wxu
via
December 15, 2023 00:23
b2ac5ff
Skptak
reviewed
Dec 15, 2023
Co-authored-by: Soren Ptak <ptaksoren@gmail.com>
Skptak
reviewed
Dec 15, 2023
Co-authored-by: Soren Ptak <ptaksoren@gmail.com>
AniruddhaKanhere
approved these changes
Dec 15, 2023
Skptak
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split builds into a separate GitHub workflow.
Build for all supported targets with multiple esp-idf versions.
Test Steps
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.