Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide additional elements (Kids Safety) #1086

Closed
opzor opened this issue Mar 3, 2021 · 7 comments
Closed

Hide additional elements (Kids Safety) #1086

opzor opened this issue Mar 3, 2021 · 7 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@opzor
Copy link

opzor commented Mar 3, 2021

I am trying to configure this app to be Safe for Kids
and I am missing few options to accomplish this:

  • Hide search bar
  • Hide comments
  • Hide video description area (about section?)
  • Hide SHARE button under the video
  • Hide UNSUBSCRIBE button under the video
  • Hide LIVE streams
  • Password protected settings
    (i would like to prevent kids from disabling HIDE features by accidentally clicking on random stuff)

If you could implement ANY of the requested features it would be wonderful. Thanks.

@opzor opzor added the enhancement New feature or request label Mar 3, 2021
@PrestonN
Copy link
Member

PrestonN commented Mar 4, 2021

Hiding different elements is pretty easy and simple to do, I'll mark this as a good first issue in case someone else would like to look into it ahead of me.

Password protecting the settings page would take a little bit more effort to do, but it isn't impossible. It isn't a priority for now, but I'd like to make it flexible to block either only the settings or the entire app. If someone else plans on working on this part then please let me know ahead of time so I can be involved.

@PrestonN PrestonN added the good first issue Good for newcomers label Mar 4, 2021
@GilgusMaximus
Copy link
Contributor

GilgusMaximus commented Mar 4, 2021

I'd also add encrypted local files to the list, because with these one would be able to add arbitrary elements to the profiles and settings.

If someone wants to collab on this, I'd be interested in discussing different aspects and also implementing different things once a design is settled. (Also once I am back to developing)

@arjpar
Copy link

arjpar commented Oct 30, 2021

I can work on this issue.

@efb4f5ff-1298-471a-8973-3d47447115dc

There is already an PR open for this one almost everything is implemented in it except for one feature #1456 (comment)

@arjpar
Copy link

arjpar commented Oct 30, 2021

Since there's already a PR open with almost everything done there's no need for me to work on this issue. Thanks for letting me know!

@elshimone
Copy link
Contributor

I think this ticket can be closed now? I have checked the following features can be hidden, either through parental settings or distraction free settings:

Hide search bar
Hide comments
Hide video description area (about section?)
Hide SHARE button under the video
Hide UNSUBSCRIBE button under the video
Hide LIVE streams

Also #2907 addresses Password protected settings. We could open another issue for encrypting the settings files, though I would be happy if my 9 year old could work around the parental controls in this app.

@efb4f5ff-1298-471a-8973-3d47447115dc

@elshimone u are correct this issue can be closed. I understand that u wouldnt mind ur child getting around that setting but from a privacy perspective we need to encrypt the password.

Usecase ur sharing a PC with a whole household and just dont want someone to snoop on ur stuff.

So yeah its best to open up an issue for that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

6 participants