-
Notifications
You must be signed in to change notification settings - Fork 768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advertise FT better in README #2677
Advertise FT better in README #2677
Conversation
Sorry requested your review to help me with the things listed in Additional context section
Why nobody reading the Additional context section :( |
Having a Pikachu as developer /s
No, at most link to a page on docs and update docs website to display images (otherwise this README might become very long)
Fine for me ._.
Change welcome but separate PR preferred
Is it repeatedly asked? If so include it |
c4046f3
Not sure about including the screenshot one. It'd definitely a nice to have but it's pretty easy to take a screenshot outside of thevapp (on windows, you just have to do Win + Shift + S and you can select an area to screenshot). Iirc the screenshot only takes a screenshot of the video so maybe that should be included in the line if you still want to keep it? I also think you should include that part in the extension section that says not all builds are supported |
README.md
Outdated
## Features | ||
* Watch videos without ads | ||
* Use YouTube without Google tracking you using cookies and JavaScript | ||
* Two extractor APIs to choose from (Built in or Invidious) | ||
* Subscribe to channels without an account | ||
* Local subscriptions, history, and saved videos | ||
* Connect to an externally setup tor proxy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe remove "tor" as the proxy doesn't have to be a tor proxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion Connect to an externally setup (tor) proxy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe Connect to an externally setup proxy such as Tor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sound good to me
README.md
Outdated
* .deb | ||
|
||
* .dmg | ||
|
||
* .exe | ||
|
||
* Flatpak | ||
|
||
* Portable (Windows only) | ||
|
||
* .rpm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are these so separated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they need to be removed stop using ur thunderbolt so fast :'(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit c886559 Merge: f4d73ca 09e61ae Author: Emma <MarmadileManteater@proton.me> Merge branch 'development' of https://github.com/MarmadileManteater/FreeTubeCordova into development commit f4d73ca Merge: 0e605d9 ae9d329 Author: Emma <MarmadileManteater@proton.me> Merge 'upstream/development' into development commit ae9d329 Author: atilluF <atilluf@outlook.com> Translated using Weblate (Italian) commit b2b9d97 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump electron-builder from 23.3.3 to 23.6.0 (FreeTubeApp#2705) commit 3c7b143 Author: Emma <MarmadileManteater@proton.me> Improving responsiveness in Settings (FreeTubeApp#2694) commit 3af6dd7 Author: Jeff Huang <s8321414@gmail.com> Translated using Weblate (Chinese (Traditional)) commit b127c85 Author: Eric <hamburger1024@mailbox.org> Translated using Weblate (Chinese (Simplified)) commit 40859b5 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Update index.js (FreeTubeApp#2706) commit 3db62f6 Author: gallegonovato <fran-carro@hotmail.es> Translated using Weblate (Spanish) commit b4bfbdc Author: Ihor Hordiichuk <igor_ck@outlook.com> Translated using Weblate (Ukrainian) commit 09e61ae Merge: 0e605d9 bdb8b17 Author: Emma <MarmadileManteater@proton.me> Merge branch 'FreeTubeApp:development' into development commit 0e605d9 Author: Emma <MarmadileManteater@proton.me> Removing custom videoJS css which is no longer necessary commit d5bc0cd Merge: ec906ef 687352f Author: Emma <MarmadileManteater@proton.me> Merge remote-tracking branch 'upstream/development' into development commit ec906ef Merge: e202c79 7ca6440 Author: Emma <MarmadileManteater@proton.me> Merge branch 'upstream_development' into development commit bdb8b17 Merge: 687352f e64db7f Author: Hosted Weblate <hosted@weblate.org> Merge branch 'origin/development' into Weblate. commit e64db7f Author: Oğuz Ersen <oguz@ersen.moe> Translated using Weblate (Turkish) commit 66e1ff3 Author: Rex_sa <rex.sa@pm.me> Translated using Weblate (Arabic) commit 687352f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump mikefarah/yq from 4.27.5 to 4.28.1 (FreeTubeApp#2703) commit 1508b05 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump lefthook from 1.1.1 to 1.1.2 (FreeTubeApp#2699) commit b3e0cc3 Author: Preston <freetubeapp@protonmail.com> Switch token for Flathub deployment commit c63149d Merge: 7fb5d47 f07aefd Author: Hosted Weblate <hosted@weblate.org> Merge branch 'origin/development' into Weblate. commit f07aefd Author: gallegonovato <fran-carro@hotmail.es> Translated using Weblate (Spanish) commit 7fb5d47 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump yt-channel-info from 3.1.0 to 3.1.1 (FreeTubeApp#2702) commit 5106868 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Update report.yml (FreeTubeApp#2704) commit ce24739 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump mini-css-extract-plugin from 2.6.0 to 2.6.1 (FreeTubeApp#2701) commit 48fe90e Merge: 22a5062 03cb0db Author: Hosted Weblate <hosted@weblate.org> Merge branch 'origin/development' into Weblate. commit 03cb0db Author: gallegonovato <fran-carro@hotmail.es> Translated using Weblate (Galician) commit eeeb903 Author: Florin Voicu <florin.bkk@gmail.com> Translated using Weblate (Romanian) commit 74f57b7 Author: HexagonCDN <ctyducliem2006@gmail.com> Translated using Weblate (Vietnamese) commit 22a5062 Author: absidue <48293849+absidue@users.noreply.github.com> Move calculateColorLuminance, calculatePublishedDate and buildVTTFileLocally out of the store (FreeTubeApp#2692) commit 7ca6440 Author: Aiz <66974576+Aiz0@users.noreply.github.com> Add shortcuts for refresh buttons on Subscription, Trending, and Popular views (FreeTubeApp#2689) commit aa4a01b Author: absidue <48293849+absidue@users.noreply.github.com> Cleanup the web webpack config (FreeTubeApp#2690) commit 41fee01 Author: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com> Improve Importing Subscriptions (FreeTubeApp#2604) commit 2154255 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Advertise FT better in README (FreeTubeApp#2677) **Full Changelog**: 0.17.1-nightly-66...0.17.1-nightly-67
Advertise FT better in README
Pull Request Type
Description
Notable things that I've done:
Screenshots
I think its better to go to https://github.com/efb4f5ff-1298-471a-8973-3d47447115dc/FreeTube/blob/marketing/README.md
Additional context
Need your help/opinion on: