Add shortcuts for refresh buttons on Subscription, Trending, and Popular views #2689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
absidue
approved these changes
Oct 8, 2022
absidue
requested review from
ChunkyProgrammer,
efb4f5ff-1298-471a-8973-3d47447115dc and
PikachuEXE
PikachuEXE
approved these changes
Oct 9, 2022
|
forgot to add "Tested locally" |
ChunkyProgrammer
approved these changes
Oct 9, 2022
github-actions
bot
removed
the
PR: waiting for review
4 tasks
MarmadileManteater
added a commit
to MarmadileManteater/FreeTubeAndroid
that referenced
this pull request
Oct 11, 2022
commit c886559 Merge: f4d73ca 09e61ae Author: Emma <MarmadileManteater@proton.me> Merge branch 'development' of https://github.com/MarmadileManteater/FreeTubeCordova into development commit f4d73ca Merge: 0e605d9 ae9d329 Author: Emma <MarmadileManteater@proton.me> Merge 'upstream/development' into development commit ae9d329 Author: atilluF <atilluf@outlook.com> Translated using Weblate (Italian) commit b2b9d97 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump electron-builder from 23.3.3 to 23.6.0 (FreeTubeApp#2705) commit 3c7b143 Author: Emma <MarmadileManteater@proton.me> Improving responsiveness in Settings (FreeTubeApp#2694) commit 3af6dd7 Author: Jeff Huang <s8321414@gmail.com> Translated using Weblate (Chinese (Traditional)) commit b127c85 Author: Eric <hamburger1024@mailbox.org> Translated using Weblate (Chinese (Simplified)) commit 40859b5 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Update index.js (FreeTubeApp#2706) commit 3db62f6 Author: gallegonovato <fran-carro@hotmail.es> Translated using Weblate (Spanish) commit b4bfbdc Author: Ihor Hordiichuk <igor_ck@outlook.com> Translated using Weblate (Ukrainian) commit 09e61ae Merge: 0e605d9 bdb8b17 Author: Emma <MarmadileManteater@proton.me> Merge branch 'FreeTubeApp:development' into development commit 0e605d9 Author: Emma <MarmadileManteater@proton.me> Removing custom videoJS css which is no longer necessary commit d5bc0cd Merge: ec906ef 687352f Author: Emma <MarmadileManteater@proton.me> Merge remote-tracking branch 'upstream/development' into development commit ec906ef Merge: e202c79 7ca6440 Author: Emma <MarmadileManteater@proton.me> Merge branch 'upstream_development' into development commit bdb8b17 Merge: 687352f e64db7f Author: Hosted Weblate <hosted@weblate.org> Merge branch 'origin/development' into Weblate. commit e64db7f Author: Oğuz Ersen <oguz@ersen.moe> Translated using Weblate (Turkish) commit 66e1ff3 Author: Rex_sa <rex.sa@pm.me> Translated using Weblate (Arabic) commit 687352f Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump mikefarah/yq from 4.27.5 to 4.28.1 (FreeTubeApp#2703) commit 1508b05 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump lefthook from 1.1.1 to 1.1.2 (FreeTubeApp#2699) commit b3e0cc3 Author: Preston <freetubeapp@protonmail.com> Switch token for Flathub deployment commit c63149d Merge: 7fb5d47 f07aefd Author: Hosted Weblate <hosted@weblate.org> Merge branch 'origin/development' into Weblate. commit f07aefd Author: gallegonovato <fran-carro@hotmail.es> Translated using Weblate (Spanish) commit 7fb5d47 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump yt-channel-info from 3.1.0 to 3.1.1 (FreeTubeApp#2702) commit 5106868 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Update report.yml (FreeTubeApp#2704) commit ce24739 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Bump mini-css-extract-plugin from 2.6.0 to 2.6.1 (FreeTubeApp#2701) commit 48fe90e Merge: 22a5062 03cb0db Author: Hosted Weblate <hosted@weblate.org> Merge branch 'origin/development' into Weblate. commit 03cb0db Author: gallegonovato <fran-carro@hotmail.es> Translated using Weblate (Galician) commit eeeb903 Author: Florin Voicu <florin.bkk@gmail.com> Translated using Weblate (Romanian) commit 74f57b7 Author: HexagonCDN <ctyducliem2006@gmail.com> Translated using Weblate (Vietnamese) commit 22a5062 Author: absidue <48293849+absidue@users.noreply.github.com> Move calculateColorLuminance, calculatePublishedDate and buildVTTFileLocally out of the store (FreeTubeApp#2692) commit 7ca6440 Author: Aiz <66974576+Aiz0@users.noreply.github.com> Add shortcuts for refresh buttons on Subscription, Trending, and Popular views (FreeTubeApp#2689) commit aa4a01b Author: absidue <48293849+absidue@users.noreply.github.com> Cleanup the web webpack config (FreeTubeApp#2690) commit 41fee01 Author: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com> Improve Importing Subscriptions (FreeTubeApp#2604) commit 2154255 Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com> Advertise FT better in README (FreeTubeApp#2677) **Full Changelog**: 0.17.1-nightly-66...0.17.1-nightly-67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shortcuts for refresh buttons on Subscription, Trending, and Popular views
Pull Request Type
Related issue
closes #2631
Description
Adds shortcuts to the 3 views with refresh buttons.
I stole the keyboard shortcut handler function from ft-video-player.js
Just a quick implementation.
Screenshots
No visible Difference
Testing
Testing should be done on all three views
RWhen the view isn't loading should perform the same action as the refresh button.Ris pressed while the view is loadingRshould no longer do anythingRinto a input element. such as the search box should not trigger a refresh.Desktop
Additional context
Since everything uses the same implementation with only differences being which function to call there ends up being a lot of code duplication. I'm open to other ways to implement it (if you could point me to the right direction).