Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup the web webpack config #2690

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Cleanup the web webpack config #2690

merged 1 commit into from
Oct 9, 2022

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 9, 2022 •
edited
Loading

Cleanup the web webpack config

Pull Request Type

  • Cleanup

Description

We've been using vue-loader for the electron renderer without specifying an options for a while now without any issues. This pull request updates the webpack config for the web build to do the same. This doesn't change the build output as vue-loader already has a dependency on vue-style-loder and uses it internally, which also means we can get rid of the explicit vue-style-loader dependency in our package.json. I also got rid of the unused style-loader dependency (vue-style-loader is vue's fork of style-loader).

Testing

yarn pack:web

I used git diff --no-index dist dist2 to compare the dist/web directory with and without these changes and the output was identical.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.17.1

@PrestonN PrestonN enabled auto-merge (squash) October 9, 2022 10:20
@github-actions github-actions bot added PR: dependencies Pull requests that update a dependency file PR: waiting for review For PRs that are complete, tested, and ready for review labels Oct 9, 2022
@PrestonN PrestonN merged commit aa4a01b into FreeTubeApp:development Oct 9, 2022
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 9, 2022
@absidue absidue deleted the web-config-cleanup branch October 9, 2022 13:10
MarmadileManteater added a commit to MarmadileManteater/FreeTubeAndroid that referenced this pull request Oct 11, 2022
@MarmadileManteater
# Automated nightly release 67
23a8014 
commit c886559
Merge: f4d73ca 09e61ae
Author: Emma <MarmadileManteater@proton.me>

Merge branch 'development' of https://github.com/MarmadileManteater/FreeTubeCordova into development

commit f4d73ca
Merge: 0e605d9 ae9d329
Author: Emma <MarmadileManteater@proton.me>

Merge 'upstream/development' into development

commit ae9d329
Author: atilluF <atilluf@outlook.com>

Translated using Weblate (Italian)

commit b2b9d97
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump electron-builder from 23.3.3 to 23.6.0 (FreeTubeApp#2705)

commit 3c7b143
Author: Emma <MarmadileManteater@proton.me>

Improving responsiveness in Settings (FreeTubeApp#2694)

commit 3af6dd7
Author: Jeff Huang <s8321414@gmail.com>

Translated using Weblate (Chinese (Traditional))

commit b127c85
Author: Eric <hamburger1024@mailbox.org>

Translated using Weblate (Chinese (Simplified))

commit 40859b5
Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>

Update index.js (FreeTubeApp#2706)

commit 3db62f6
Author: gallegonovato <fran-carro@hotmail.es>

Translated using Weblate (Spanish)

commit b4bfbdc
Author: Ihor Hordiichuk <igor_ck@outlook.com>

Translated using Weblate (Ukrainian)

commit 09e61ae
Merge: 0e605d9 bdb8b17
Author: Emma <MarmadileManteater@proton.me>

Merge branch 'FreeTubeApp:development' into development

commit 0e605d9
Author: Emma <MarmadileManteater@proton.me>

Removing custom videoJS css which is no longer necessary

commit d5bc0cd
Merge: ec906ef 687352f
Author: Emma <MarmadileManteater@proton.me>

Merge remote-tracking branch 'upstream/development' into development

commit ec906ef
Merge: e202c79 7ca6440
Author: Emma <MarmadileManteater@proton.me>

Merge branch 'upstream_development' into development

commit bdb8b17
Merge: 687352f e64db7f
Author: Hosted Weblate <hosted@weblate.org>

Merge branch 'origin/development' into Weblate.

commit e64db7f
Author: Oğuz Ersen <oguz@ersen.moe>

Translated using Weblate (Turkish)

commit 66e1ff3
Author: Rex_sa <rex.sa@pm.me>

Translated using Weblate (Arabic)

commit 687352f
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump mikefarah/yq from 4.27.5 to 4.28.1 (FreeTubeApp#2703)

commit 1508b05
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump lefthook from 1.1.1 to 1.1.2 (FreeTubeApp#2699)

commit b3e0cc3
Author: Preston <freetubeapp@protonmail.com>

Switch token for Flathub deployment

commit c63149d
Merge: 7fb5d47 f07aefd
Author: Hosted Weblate <hosted@weblate.org>

Merge branch 'origin/development' into Weblate.

commit f07aefd
Author: gallegonovato <fran-carro@hotmail.es>

Translated using Weblate (Spanish)

commit 7fb5d47
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump yt-channel-info from 3.1.0 to 3.1.1 (FreeTubeApp#2702)

commit 5106868
Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>

Update report.yml (FreeTubeApp#2704)

commit ce24739
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bump mini-css-extract-plugin from 2.6.0 to 2.6.1 (FreeTubeApp#2701)

commit 48fe90e
Merge: 22a5062 03cb0db
Author: Hosted Weblate <hosted@weblate.org>

Merge branch 'origin/development' into Weblate.

commit 03cb0db
Author: gallegonovato <fran-carro@hotmail.es>

Translated using Weblate (Galician)

commit eeeb903
Author: Florin Voicu <florin.bkk@gmail.com>

Translated using Weblate (Romanian)

commit 74f57b7
Author: HexagonCDN <ctyducliem2006@gmail.com>

Translated using Weblate (Vietnamese)

commit 22a5062
Author: absidue <48293849+absidue@users.noreply.github.com>

Move calculateColorLuminance, calculatePublishedDate and buildVTTFileLocally out of the store (FreeTubeApp#2692)

commit 7ca6440
Author: Aiz <66974576+Aiz0@users.noreply.github.com>

Add shortcuts for refresh buttons on Subscription, Trending, and Popular views (FreeTubeApp#2689)

commit aa4a01b
Author: absidue <48293849+absidue@users.noreply.github.com>

Cleanup the web webpack config (FreeTubeApp#2690)

commit 41fee01
Author: ChunkyProgrammer <78101139+ChunkyProgrammer@users.noreply.github.com>

Improve Importing Subscriptions (FreeTubeApp#2604)

commit 2154255
Author: efb4f5ff-1298-471a-8973-3d47447115dc <73130443+efb4f5ff-1298-471a-8973-3d47447115dc@users.noreply.github.com>

Advertise FT better in README (FreeTubeApp#2677)

**Full Changelog**: 0.17.1-nightly-66...0.17.1-nightly-67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

Assignees
No one assigned
Labels
PR: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @PrestonN