Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tag manager to FUG website #868

Closed
PatReynolds opened this issue Aug 13, 2018 · 19 comments
Closed

Add Tag manager to FUG website #868

PatReynolds opened this issue Aug 13, 2018 · 19 comments
Assignees
Milestone

Comments

@PatReynolds
Copy link

PatReynolds commented Aug 13, 2018

needs #867

@DeniseColbert
Copy link

Emailed Rich to advise Bev 10/10

@PatReynolds
Copy link
Author

When does it kick in - before or after consent

@PatReynolds
Copy link
Author

Conversation on Slack asking if Scott should help out here.

@DeniseColbert DeniseColbert assigned ghost and unassigned bev-fc Nov 21, 2018
@DeniseColbert
Copy link

Added Gray (and removed Bev, at her request)

@ghost
Copy link

ghost commented Nov 22, 2018

@DeniseColbert Can this functionality wait until switching the CMS? (I know WordPress includes full taxonomy management "out of the box")

@DeniseColbert
Copy link

How soon might we be in that position, @arswright-alt-uk?

@ghost
Copy link

ghost commented Nov 28, 2018

@DeniseColbert Cancel that - I thought this referred to CMS taxonomy management (just now noticed the "Analytics" tag) - we can proceed straightaway, just need the Google Tag Manager installation code.

Recommend adding Google Analytics (+ other desired tags as applicable) and publishing the container before retrieving the installation code to ensure things behave as expected when code is installed.

@DeniseColbert
Copy link

I've given you access to GTM: Read for containers. Let me know if you need more/different.

@ghost
Copy link

ghost commented Nov 28, 2018

Install code obtained but container not yet published - I will probably need the Edit permission to change configuration (subject to approval) and I would need the Publish permission to proceed on my own, though anyone with that permission could publish the present configuration if it's correct.

Install code:

<head>

<!-- Google Tag Manager -->
<script>(function(w,d,s,l,i){w[l]=w[l]||[];w[l].push({'gtm.start':
new Date().getTime(),event:'gtm.js'});var f=d.getElementsByTagName(s)[0],
j=d.createElement(s),dl=l!='dataLayer'?'&l='+l:'';j.async=true;j.src=
'https://www.googletagmanager.com/gtm.js?id='+i+dl;f.parentNode.insertBefore(j,f);
})(window,document,'script','dataLayer','GTM-PJP93GW');</script>
<!-- End Google Tag Manager -->

<body>

<!-- Google Tag Manager (noscript) -->
<noscript><iframe src="https://www.googletagmanager.com/ns.html?id=GTM-PJP93GW"
height="0" width="0" style="display:none;visibility:hidden"></iframe></noscript>
<!-- End Google Tag Manager (noscript) -->

@DeniseColbert
Copy link

DeniseColbert commented Nov 28, 2018

Publish access given, if you're happy to proceed. The ID matches the correct account, I think it's good to go.

@richpomfret do we know how this will interplay with cookies etc? I.e. when things need to be triggered?

@richpomfret
Copy link
Collaborator

@DeniseColbert @arswright-alt-uk is this now live? In terms of GDPR, no marketing tags should be fired until cookie consent is given (or set to 'true' depending upon how Bev implemented it). IF tags are fired without consent, the quickest fix may be to ensure anonymize Ip setting is switched on in Tag manager (I believe we have it in Analytics but Tag manager might affect that).

@ghost
Copy link

ghost commented Dec 11, 2018

@richpomfret Not live yet - GDPR was one of several considerations I need to address in testing (also need to mirror custom Google Analytics functionality in Google Tag Manager, confirm cross-domain tracking works, etc). Will update this task w/progress.

@ghost
Copy link

ghost commented Jan 4, 2019

@richpomfret Short answer: Looks OK at present (by the site's present configuration, IP's are anonymized and Google Analytics AdSense features are disabled in compliance with GDPR - scripts still fire but functionality is limited - unless/until the user sets a cookie to indicate acceptance).

Long answer: per FreeUKGen/FreeUKGenealogy/issues/26 I took an inventory of existing Google Analytics configuration in preparation for use of Google Tag Manager - it appears as though the loadGoogleScripts and gaOptout functions are not referenced in the codebase (likewise there is no element with the ID acceptAnalytic - resulting in a Javascript error for all pages), however, loadAnalyticScripts does check acceptAnalyticIsSet and will anonymize IP if user has not set the acceptance cookie for Analytics and loadAdsenseScripts will similarly disable allowAdFeatures for Google Analytics if user has not set the acceptance cookie for AdSense.

@PatReynolds
Copy link
Author

Rich to let Gray know that paper approvied, and set up conversation between Lemon and Gray re set up on AWS server

@richpomfret
Copy link
Collaborator

Done a little while ago. I wonder whether this will be on hold until the Wordpress update has been made.

@ghost
Copy link

ghost commented Feb 12, 2019

@richpomfret

I wonder whether this will be on hold until the Wordpress update has been made.

I'd like to address the Craft Transfer to AWS (FreeUKGenealogy/issues/5) and any relatively-minor Craft fixes as prioritized by @DeniseColbert immediately with the goal of establishing as much of the desired functionality and content as possible before a feature freeze to support WordPress Migration (FreeUKGenealogy/issues/44) - will proceed through backlog as prioritized.

@richpomfret
Copy link
Collaborator

Thanks for clarifying and sounds good to me @arswright-alt-uk

@richpomfret
Copy link
Collaborator

I think this now needs to go 'on ice' until we make a decision on Wordpress rollout (considering the resourcing situation for this). It may well be desirable for us to go ahead and add in TAG manager when we roll it out on our other projects too (make it one big project, once we get to that stage in BMD2).

@richpomfret
Copy link
Collaborator

We now have a new volunteer to help with this. However, we need to discuss how we might rollout Wordpress to replace Craft - which ideally should happen before GTA is implemented. IF too problematic, I would suggest moving ahead with using custom templates for GTA in the meantime (in order to handle GDPR settings with cookies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants