[BUGFIX] contrib: yanic-import-timestamp for latest hopglass timestamp format #67

mweinelt · 2017-05-31T15:35:27Z

No description provided.

genofire · 2017-05-31T16:08:01Z

Auch wenn keiner mehr version 1 nutzt, sollte dort ebenfalls eine importierung auf Zeitzonen stand finden.
Ggf. auch wirklich eine Überprüfung, ob und in welchen Zeitzonenformat es sich handelt.

mweinelt · 2017-05-31T16:30:35Z

ffmap-backend nutzt datetime.datetime.now().isoformat()

>>> import datetime
>>> datetime.datetime.now().isoformat()
'2017-05-31T18:30:19.759610'

Das dürfte doch Version 1 sein, oder?

corny · 2017-06-01T12:45:53Z

contrib/yanic-import-timestamp

@@ -35,7 +35,7 @@ if oldnodedb['version'] == 2:
    for nodeid, node in newnodedb['nodes'].items():
        for oldnode in oldnodedb['nodes']:
            if oldnode['nodeinfo']['node_id'] == nodeid:
-                node['firstseen'] = "{}+0100".format(oldnode['firstseen'])
+                node['firstseen'] = "{}+0100".format(oldnode['firstseen'][:-5])


Really? Always remove the last 5 bytes? I think a regexp replacement is better in this case.

If that's not a sufficient solution for a lazy migration script I'd rather use datetime.strptime.

coveralls · 2017-06-02T22:03:48Z

Coverage remained the same at 57.457% when pulling 866f89e on mweinelt:master into 88975d2 on FreifunkBremen:master.

coveralls · 2017-06-02T22:04:43Z

Coverage increased (+0.2%) to 57.688% when pulling 866f89e on mweinelt:master into 88975d2 on FreifunkBremen:master.

genofire

Better but still not perfect.
(Sry)

genofire · 2017-06-03T01:17:39Z

contrib/yanic-import-timestamp

+                dt = datetime.strptime(oldnode['firstseen'], v2_date_format)
+                dts = dt.strftime(yanic_date_format)
+                if node['firstseen'] != dts:
+                    node['firstseen'] = dt.strftime(yanic_date_format)


warum nicht dts wie in version 1?

unvollständig refactored …

genofire · 2017-06-03T02:11:07Z

contrib/yanic-import-timestamp

    for nodeid, node in newnodedb['nodes'].items():
        for oldnode in oldnodedb['nodes']:
            if oldnode['nodeinfo']['node_id'] == nodeid:
-                node['firstseen'] = "{}+0100".format(oldnode['firstseen'])
-                count+=1
+                dt = datetime.strptime(oldnode['firstseen'], v2_date_format)


It would not be so easy 😢
The ffmap-backend could also generate v2.
See here: https://github.com/ffnord/ffmap-backend/blob/respondd/lib/nodes.py#L53-L55
We need a try, if it is a timestamp with timezone.

Maybe something like if 'Z' in old and if '+' in old else with v1 form
and a try at the end with dt is over 0 and error handling (maybe a function for both v1 and v2)

Also some additional refactoring and more verbosity.

coveralls · 2017-06-03T12:43:56Z

Coverage increased (+0.2%) to 57.688% when pulling 09f8bd5 on mweinelt:master into 88975d2 on FreifunkBremen:master.

genofire

Bin mir nocht ganz sicher, ob bei v1_datezone_format nicht lieber doch die Zeitzone +1 nicht +0 genommen werden sollte. Doch ein Stunde Abweichung inzweifelsfall fällt nun wirklich nicht ins Gewicht.
Vielen Dank für die Überarbeitung.

mweinelt · 2017-06-03T17:55:24Z

https://docs.python.org/3/library/datetime.html#datetime.datetime.now

datetime.now() enthält per default keine tzinfo und ist daher naiv, also UTC. Daher ist die Zeitzone +0000, nicht +0100 (CET) oder gar +0200 (CEST).

corny reviewed Jun 1, 2017

View reviewed changes

genofire added the wip label Jun 1, 2017

genofire changed the title ~~contrib: update yanic-import-timestamp for latest hopglass timestamp format~~ [BUGFIX] contrib: yanic-import-timestamp for latest hopglass timestamp format Jun 1, 2017

mweinelt force-pushed the master branch 2 times, most recently from 107926d to 866f89e Compare June 2, 2017 22:02

genofire requested changes Jun 3, 2017

View reviewed changes

[BUGFIX] yanic-import-timestamp: properly parse timestamps with strptime

09f8bd5

Also some additional refactoring and more verbosity.

mweinelt force-pushed the master branch from 866f89e to 09f8bd5 Compare June 3, 2017 12:41

genofire approved these changes Jun 3, 2017

View reviewed changes

genofire added review and removed wip labels Jun 12, 2017

genofire merged commit de96847 into FreifunkBremen:master Jun 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUGFIX] contrib: yanic-import-timestamp for latest hopglass timestamp format #67

[BUGFIX] contrib: yanic-import-timestamp for latest hopglass timestamp format #67

mweinelt commented May 31, 2017

genofire commented May 31, 2017

mweinelt commented May 31, 2017

corny Jun 1, 2017

mweinelt Jun 1, 2017

coveralls commented Jun 2, 2017 •

edited

Loading

coveralls commented Jun 2, 2017 •

edited

Loading

genofire left a comment

genofire Jun 3, 2017

mweinelt Jun 3, 2017

genofire Jun 3, 2017

coveralls commented Jun 3, 2017 •

edited

Loading

genofire left a comment

mweinelt commented Jun 3, 2017

[BUGFIX] contrib: yanic-import-timestamp for latest hopglass timestamp format #67

[BUGFIX] contrib: yanic-import-timestamp for latest hopglass timestamp format #67

Conversation

mweinelt commented May 31, 2017

genofire commented May 31, 2017

mweinelt commented May 31, 2017

corny Jun 1, 2017

Choose a reason for hiding this comment

mweinelt Jun 1, 2017

Choose a reason for hiding this comment

coveralls commented Jun 2, 2017 • edited Loading

coveralls commented Jun 2, 2017 • edited Loading

genofire left a comment

Choose a reason for hiding this comment

genofire Jun 3, 2017

Choose a reason for hiding this comment

mweinelt Jun 3, 2017

Choose a reason for hiding this comment

genofire Jun 3, 2017

Choose a reason for hiding this comment

coveralls commented Jun 3, 2017 • edited Loading

genofire left a comment

Choose a reason for hiding this comment

mweinelt commented Jun 3, 2017

coveralls commented Jun 2, 2017 •

edited

Loading

coveralls commented Jun 2, 2017 •

edited

Loading

coveralls commented Jun 3, 2017 •

edited

Loading