Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config.default.php should be along the code #1531

Closed
oupala opened this issue May 11, 2017 · 5 comments
Closed

config.default.php should be along the code #1531

oupala opened this issue May 11, 2017 · 5 comments

Comments

@oupala
Copy link
Contributor

oupala commented May 11, 2017

In my opinion, if config.default.php should be updated with FreshRSS update, it does not belong to user data, and hence should not be present in data directory. It should be along the code, somewhere else. In my case, the data directory is outside FreshRSS's directory (and symlinked) to that I can update FreshRSS source code without any risk of erasing my user data.

@Alkarex Alkarex added this to the 1.7.0 milestone May 12, 2017
Alkarex added a commit to Alkarex/FreshRSS that referenced this issue May 12, 2017
@Alkarex
Copy link
Member

Alkarex commented May 12, 2017

Addressed in #1532

@oupala
Copy link
Contributor Author

oupala commented May 12, 2017

Great !

You should also mention in the changelog or somewhere in the update instructions to remove the existing config.default.php file from the USERS_PATH.

@Alkarex
Copy link
Member

Alkarex commented May 12, 2017

Moving the old files should be done automatically by git pull or the future ZIP update.

Alkarex added a commit to Alkarex/FreshRSS that referenced this issue May 12, 2017
@Alkarex
Copy link
Member

Alkarex commented May 12, 2017

There is a note in the changelog Alkarex@68d3dee

@Alkarex
Copy link
Member

Alkarex commented Jun 10, 2017

#1519

javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
javerous pushed a commit to javerous/FreshRSS that referenced this issue Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants