-
-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1464 Improve English Translations #1465
1464 Improve English Translations #1465
Conversation
Release 1.6.3
…ce for english-speaking users.
app/i18n/en/conf.php
Outdated
@@ -142,7 +142,7 @@ | |||
'_' => 'Shortcuts', | |||
'article_action' => 'Article actions', | |||
'auto_share' => 'Share', | |||
'auto_share_help' => 'If there is only one sharing mode, it is used. Else modes are accessible by their number.', | |||
'auto_share_help' => 'If there is only one sharing mode, it is used. Other modes are accessible by their number.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that "else" was used as in "otherwise" here - not "other", which would make more sense.
I'm fine with otherwise rather than other here.
…On Tue, Mar 21, 2017, 16:19 Alwaysin ***@***.***> wrote:
***@***.**** requested changes on this pull request.
------------------------------
In app/i18n/en/conf.php
<#1465 (comment)>:
> @@ -142,7 +142,7 @@
'_' => 'Shortcuts',
'article_action' => 'Article actions',
'auto_share' => 'Share',
- 'auto_share_help' => 'If there is only one sharing mode, it is used. Else modes are accessible by their number.',
+ 'auto_share_help' => 'If there is only one sharing mode, it is used. Other modes are accessible by their number.',
I think that "else" was used as in "otherwise" here - not "other", which
would make more sense.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1465 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACFTreZ2ntx7DsPkxNyjyCx48fuYwlMKks5roD7sgaJpZM4MkGHC>
.
|
app/i18n/en/admin.php
Outdated
@@ -138,7 +138,7 @@ | |||
'number_entries' => '%d articles', | |||
'percent_of_total' => '%% of total', | |||
'repartition' => 'Articles repartition', | |||
'status_favorites' => 'Favourites', | |||
'status_favorites' => 'Favorites', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both are correct. One is for US, the other one is for UK. I have no preference even though I am more used to "Favourites"
Look good to me. @jlefler thanks |
Add credits. Keep British spelling of favourites in the user interface, USA spelling in the code.
Merged. Thanks again! |
@@ -2,7 +2,7 @@ | |||
|
|||
return array( | |||
'action' => array( | |||
'actualize' => 'Actualize', | |||
'actualize' => 'Updating', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in #1492
I would also change the "damn!" in error messages to something slightly more proper even if it's only a stylistic issue. |
…anslations 1464 Improve English Translations
This pull request has no functional changes. It merely updates the English translation with minor changes to word choice and grammar to improve the user experience for English-speaking users. The incorrect translation that prompted the change was 'Actualise' when performing a feed update. I have replaced that with "Updating" and made other similar changes. Fixes #1464.