Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonApiListener does not respect "include" query parameter if "fields" query parameter is used. #174

Open
geoidesic opened this issue Aug 13, 2022 · 0 comments
Open

JsonApiListener does not respect "include" query parameter if "fields" query parameter is used. #174

geoidesic opened this issue Aug 13, 2022 · 0 comments

Comments

@geoidesic
Copy link
Collaborator

geoidesic commented Aug 13, 2022 •
edited
Loading

E.g.

{{protocol}}{{domain}}/api/people/3c9b642a-6682-4b7a-aff2-1928371923719?fields[people]=role&include=role

This will not include any data and currently produces the same result as this query:

{{protocol}}{{domain}}/api/people/3c9b642a-6682-4b7a-aff2-1928371923719?fields[people]=role

Which means that there is no way currently to fetch a single entity and only receive some of its related data, which means GET entity requests will be exponentially slower – a ticking time-bomb in your app. Nice. Hard to believe no-one noticed this before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@geoidesic