Add MultiLockHandler and MultiSemaphore helpers #13
Conversation
.gitignore
Outdated
| /build/ | ||
| /consul-configuration/data-dir/ | ||
| /vendor/ | ||
| /.idea |
There was a problem hiding this comment.
This one should be removed. This should be in your personal global ignore list instead.
|
I have fixed all issues from comments |
Consul/Helper/MultiLockHandler.php
Outdated
| $result = true; | ||
|
|
||
| // Start a session | ||
| $session = $this->session->create('{"LockDelay":0, "TTL": "'.$this->ttl.'s"}')->json(); |
There was a problem hiding this comment.
May be it's better to use json_encode here. For example, ttl value is never controlled...
There was a problem hiding this comment.
json_encode will not protect us from wrong ttl value
So i have added validation for ttl in constructor
Do you think it is fine?
|
Good work ! |
|
I have made changes for all issues from comments |
|
@kufd Do you still need this PR? (sorry for the HUGE delay :) ) |
|
@lyrixx I do not need it |
|
Can you
Thanks |
|
@lyrixx would you like to merge this request? However, if you would like to merge the pull request I will prepare it. |
|
I'm OK to merge it 👍🏼 |
|
I will prepare this PR i a few days |
|
@lyrixx, i updated the pull request |
|
@lyrixx I added some documentation and made fixes |
|
Here we go 🎉 ! Thanks for your patience and for the hard work. |
|
Finally))) |
I have added 2 helpers MultiLockHandler and MultiSemaphore which i use in my projects.
So i think it will be usefull for other developers