Doing some cleanup of all the Warnings that litter the build #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stelzi79
changed the title
CS8618: Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.
CS1998: Async method lacks 'await' operators and will run synchronously
…ntries so we tell the compiler that it is that way and doesn't warn us about this possibly being null!
ull in order to test if it is set correctly at all!
Stelzi79
force-pushed
the
Stelzi79/Warnings_cleanup_to_GHIssues
branch
2 times, most recently
from
af176ff
to
43e25ef
Compare
Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.
…dia_attachments! Possibly it is connected with the missing Null annotations in Messages.cs! This whole assignment makes the compiler 'mad' in several parts with multiple different Warnings. At a first glance I wasn't clear to me how to fix these warnings!
…ll value when exiting constructor. Consider declaring as nullable.
…must contain a non-null value when exiting constructor. Consider declaring as nullable.
…field must contain a non-null value when exiting constructor. Consider declaring as nullable.
… must contain a non-null value when exiting constructor. Consider declaring as nullable.
Stelzi79
force-pushed
the
Stelzi79/Warnings_cleanup_to_GHIssues
branch
from
3063bf9
to
8caba5e
Compare
…CS8622 -- Nullability of reference types in type of parameter doesn't match the target delegate (possibly because of nullability attributes).
Stelzi79
force-pushed
the
Stelzi79/Warnings_cleanup_to_GHIssues
branch
from
8caba5e
to
e025d7c
Compare
…CS8622 -- Nullability of reference types in type of parameter doesn't match the target delegate (possibly because of nullability attributes).
Stelzi79
force-pushed
the
Stelzi79/Warnings_cleanup_to_GHIssues
branch
from
3bbdd40
to
ca23a69
Compare
…plaining about it.
|
The local runner is not staying connected to GitHub. I've switched back to the ubuntu-latest running in dotnet.yml and recommend you do the same |
…- Argument cannot be used for parameter due to differences in the nullability of reference types.
|
I should follow more often my own advice ... 🤔 This PR is getting way to big and issues from Rebase creeps in. I will break this PR down in smaller chunks and open separate PRs for them. |
This was referenced Sep 6, 2023
|
I have now splitt out all the commits that make sense for now. I will open additional PRs when the time allows it to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing some cleanup of all the Warnings that litter the build and create TODOs (and Issues) to at least silence all these many many Warnings.
I also fix some small stuff that are very obvious to fix or there are "just" some hints needed for the compiler.