Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doing some cleanup of all the Warnings that litter the build - Part 3 #187

Merged

Conversation

Stelzi79
Copy link
Contributor

@Stelzi79 Stelzi79 commented Sep 6, 2023

As mentioned in #180 thes are the first 5 commits from this draft PR.

This PR will create some Issues from the added TODOs!

…dia_attachments!

Possibly it is connected with the missing Null annotations in Messages.cs!
This whole assignment makes the compiler 'mad' in several parts with multiple different Warnings.
At a first glance I wasn't clear to me how to fix these warnings!
…ll value when exiting constructor. Consider declaring as nullable.
…must contain a non-null value when exiting constructor. Consider declaring as nullable.
…field must contain a non-null value when exiting constructor. Consider declaring as nullable.
… must contain a non-null value when exiting constructor. Consider declaring as nullable.
@Stelzi79 Stelzi79 changed the title Doing some cleanup of all the Warnings that litter the build - Part 2 Doing some cleanup of all the Warnings that litter the build - Part 3 Sep 6, 2023
@csharpfritz csharpfritz merged commit 50b5d3e into FritzAndFriends:main Sep 12, 2023
4 checks passed
@Stelzi79 Stelzi79 deleted the Stelzi79/Warnings_cleanup_part03 branch September 12, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants