Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix formatting action #202

Merged
merged 2 commits into from
Sep 12, 2023

Conversation

degenone
Copy link
Contributor

@degenone degenone commented Sep 11, 2023

Unfortunately even with my change to commit step, it still doesn't have permissions. With continue-on-error: true the other jobs in the workflow are not blocked by code-formatting failing.

In order to trigger formatting/commit I corrected a Naming Rule violation in src/TagzApp.Web/Pages/Error.cshtml.cs: _logger;_Logger;

commit step error:

On branch fix_Formatting
Your branch is up to date with 'origin/fix_Formatting'.

Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
	modified:   src/TagzApp.Web/Pages/Error.cshtml.cs

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   src/.editorconfig
[fix_Formatting 7a3476a] Applying formatting changes through GitHub Actions
 1 file changed, 27 insertions(+), 27 deletions(-)
remote: Permission to degenone/TagzApp.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/degenone/TagzApp/': The requested URL returned error: 403
Error: Process completed with exit code 128.

Do we want to keep the job commented out or make this change? It would add a bit of time to the workflows. With just one file in this PR, Run dotnet format step took 48 seconds.

@csharpfritz
Copy link
Contributor

I'm ok with files that don't meet our coding standards taking longer to format. Consider it a penalty for not abiding by our formatting rules :)

@csharpfritz csharpfritz merged commit 4a8bd8a into FritzAndFriends:main Sep 12, 2023
4 checks passed
@degenone degenone deleted the fix_Formatting branch September 12, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants