Enable Python 3.9 in continuous integration

[jayaddison]

• Remove Python 3.5 continuous integration builds (it's now past end-of-life according to the Python download page)
• Enable Python 3.9

[honzajavorek]

Removing 3.5 is a breaking change for frozen-flask, no matter the end of life. The policy is to follow whatever flask itself tests against. I'm inclined to releasing a breaking version, which would drop support for obsolete Python versions (opinions, @tswast?), but then let's do it properly. I quickly checked what versions are supported by flask and it seems they might have dropped even the 2.x line 😮

So my idea would be that we add support for 3.9 and release a minor version. Then we could prepare a version, which drops all the old stuff unsupported by Flask, and only then release a breaking version.

[honzajavorek]

OK I now noticed that frozen-flask is version 0.15, so I'm not sure how closely it follows the semantic versioning scheme. I think a project used by ~2000 ppl and with history going back to 2011 deserves to take off with a "stable" v1.0.0, with which we could drop the old Python version, and from which we could follow with sem ver. Since I'm fairly new here, I'll wait for @tswast's opinions on all this.

[jayaddison]

Ah, I just missed your latest comment before pushing changes. Will pause to hear the preferred approach.

[honzajavorek]

I think we can add 3.9 just fine, but we should sync on how to drop the old stuff before doing that.

…

On Thu 26. 11. 2020 at 17:10, James Addison ***@***.***> wrote: Ah, I just missed your latest comment before pushing changes. Will pause to hear the preferred approach. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#110 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACFGMNNKF7ESMLRFELBQ6DSRZ4YJANCNFSM4UD4NDXQ> .

[jayaddison]

@tswast @honzajavorek Not urgent, but I'm wondering if there's been any further discussion about releasing an updated minor version of frozen-flask with Python 3.9 support?

[tswast]

I'm wondering if there's been any further discussion about releasing an updated minor version of frozen-flask with Python 3.9 support?

I may have missed it, but were there PRs to fix the library to support Python 3.9? Even without the 3.9 classifier in setup.py, it should be possible to install on 3.9, since there isn't a python_requires field that would prevent it.

[jayaddison]

@tswast Yep; my understanding (which may have clouded over a bit since I last looked into this) is that #98 added Py3.9 compatibility, and since then #107 has fixed an incompatibility encountered when using Py2.7.

To be thorough perhaps we should go back and discover when those test failures for Py2.7 began and understand that before a release; the issue relates to handling of multi-byte unicode characters in URLs.

[jayaddison]

(taking a look into this now, to try to identify what initially caused the Py2.7 test failures)

[jayaddison]

Ok, so the test was introduced a while back in b43242a in May 2011, and while it's neat that it uses Unicode everywhere, I think Python 2.7's urllib.unquote is behaving within the URI spec as-written. Perhaps only IRIs may contain multibyte characters?