Error on each build of Libssh2, seems to be a non-issue

[benharold]

Whenever I run iSSH2.sh, OpenSSL builds just fine but I keep getting errors when building Libssh2.

Initializing...

Libssh2 version: 1.8.0 (Automatically detected)
OpenSSL version: 1.1.0g (Automatically detected)
SDK version: 11.2 (Automatically detected)
Architectures: armv7 armv7s arm64 x86_64
OS min version: 8.0

Downloading openssl-1.1.0g.tar.gz
######################################################################## 100.0%
MD5: ba5f1b8b835b88cadbce9b35ed9531a6
Extracting openssl-1.1.0g.tar.gz
Building OpenSSL 1.1.0g, please wait...
- iPhoneOS armv7 done!
- iPhoneOS armv7s done!
- iPhoneOS arm64 done!
- iPhoneSimulator x86_64 done!
Building libssl.a fat library...
Building libcrypto.a fat library...
Copying headers...
Building done.
Downloading libssh2-1.8.0.tar.gz
######################################################################## 100.0%
MD5: 3d1147cae66e2959ea5441b183de1b1c
Extracting libssh2-1.8.0.tar.gz
Building Libssh2 1.8.0:
Build failed, cleaning up temporary files...

However, it appears that the libssha2.a file is actually compiled successfully, as the next pass of iSSH2.sh shows the following output:

...
Copying headers...
Building done.
libssh2-1.8.0.tar.gz already exists
MD5: 3d1147cae66e2959ea5441b183de1b1c
Extracting libssh2-1.8.0.tar.gz
Building Libssh2 1.8.0:
libssh2.a for armv7 already exists.
Build failed, cleaning up temporary files...

The next run yields:

...
Copying headers...
Building done.
libssh2-1.8.0.tar.gz already exists
MD5: 3d1147cae66e2959ea5441b183de1b1c
Extracting libssh2-1.8.0.tar.gz
Building Libssh2 1.8.0:
libssh2.a for armv7 already exists.
libssh2.a for armv7s already exists.
Build failed, cleaning up temporary files...

This goes on until all of the libraries seemingly compile correctly:

Copying headers...
Building done.
libssh2-1.8.0.tar.gz already exists
MD5: 3d1147cae66e2959ea5441b183de1b1c
Extracting libssh2-1.8.0.tar.gz
Building Libssh2 1.8.0:
libssh2.a for armv7 already exists.
libssh2.a for armv7s already exists.
libssh2.a for arm64 already exists.
libssh2.a for x86_64 already exists.
Building libssh2.a fat library...
Copying headers...
Building done.
Cleaning up temporary files...

This is the end of the compile log of a failure:

make[2]: Nothing to be done for `install-exec-am'.
 /usr/local/bin/gmkdir -p '/var/folders/bk/d1v9y42n50q1m_bqwrjm5cjm0000gq/T/iSSH2/libssh2-1.8.0/iPhoneSimulator11.2-x86_64/lib/pkgconfig'
 /usr/local/bin/gmkdir -p '/var/folders/bk/d1v9y42n50q1m_bqwrjm5cjm0000gq/T/iSSH2/libssh2-1.8.0/iPhoneSimulator11.2-x86_64/include'
 /usr/local/bin/ginstall -c -m 644 include/libssh2.h include/libssh2_publickey.h include/libssh2_sftp.h '/var/folders/bk/d1v9y42n50q1m_bqwrjm5cjm0000gq/T/iSSH2/libssh2-1.8.0/iPhoneSimulator11.2-x86_64/include'
 /usr/local/bin/ginstall -c -m 644 libssh2.pc '/var/folders/bk/d1v9y42n50q1m_bqwrjm5cjm0000gq/T/iSSH2/libssh2-1.8.0/iPhoneSimulator11.2-x86_64/lib/pkgconfig'
ginstall: 'include/libssh2.h' and '/var/folders/bk/d1v9y42n50q1m_bqwrjm5cjm0000gq/T/iSSH2/libssh2-1.8.0/iPhoneSimulator11.2-x86_64/include/libssh2.h' are the same file
ginstall: 'include/libssh2_publickey.h' and '/var/folders/bk/d1v9y42n50q1m_bqwrjm5cjm0000gq/T/iSSH2/libssh2-1.8.0/iPhoneSimulator11.2-x86_64/include/libssh2_publickey.h' are the same file
ginstall: 'include/libssh2_sftp.h' and '/var/folders/bk/d1v9y42n50q1m_bqwrjm5cjm0000gq/T/iSSH2/libssh2-1.8.0/iPhoneSimulator11.2-x86_64/include/libssh2_sftp.h' are the same file
make[2]: *** [install-includeHEADERS] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [install-am] Error 2
make: *** [install-recursive] Error 1

I haven't actually tried using the compiled libraries yet.

[Frugghi]

@benharold I'm not sure how to reproduce your issue (it does compile fine for me), but it seems that something wrong is happening during the install phase of libssh2. I've pushed a new commit that might fix the issue, could you test it and confirm? Thanks!

[benharold]

I pulled the latest commit and re-ran the script. Everything went off without a hitch. Thanks for your help.

[I] ➜ ./iSSH2.sh
Initializing...

Libssh2 version: 1.8.0 (Automatically detected)
OpenSSL version: 1.1.0g (Automatically detected)
SDK version: 11.2 (Automatically detected)
Architectures: armv7 armv7s arm64 x86_64
OS min version: 8.0

Downloading openssl-1.1.0g.tar.gz
######################################################################## 100.0%
MD5: ba5f1b8b835b88cadbce9b35ed9531a6
Extracting openssl-1.1.0g.tar.gz
Building OpenSSL 1.1.0g, please wait...
- iPhoneOS armv7 done!
- iPhoneOS armv7s done!
- iPhoneOS arm64 done!
- iPhoneSimulator x86_64 done!
Building libssl.a fat library...
Building libcrypto.a fat library...
Copying headers...
Building done.
Downloading libssh2-1.8.0.tar.gz
######################################################################## 100.0%
MD5: 3d1147cae66e2959ea5441b183de1b1c
Extracting libssh2-1.8.0.tar.gz
Building Libssh2 1.8.0:
- iPhoneOS armv7 done!
- iPhoneOS armv7s done!
- iPhoneOS arm64 done!
- iPhoneSimulator x86_64 done!
Building libssh2.a fat library...
Copying headers...
Building done.
Cleaning up temporary files...