Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas benchmarks are broken #1164

Closed
Dentosal opened this issue Apr 26, 2023 · 0 comments · Fixed by #1166
Closed

Gas benchmarks are broken #1164

Dentosal opened this issue Apr 26, 2023 · 0 comments · Fixed by #1166
Assignees
@Dentosal
Labels
bug Something isn't working

Comments

@Dentosal
Copy link
Member

They haven't been updated after HP pointer changes in fuel-vm, which is causing some memory addresses to be incorrect. There might be other issues as well.
@Dentosal Dentosal added the bug Something isn't working label Apr 26, 2023
@Dentosal Dentosal self-assigned this Apr 26, 2023
@Dentosal Dentosal mentioned this issue Apr 27, 2023
Merged
Dentosal added a commit that referenced this issue Apr 28, 2023
@Dentosal @freesig
Update fuel-vm to 0.31 for gas benchmarks (#1166)
75697b3 
Fixes #1164. Prepares for wide math intstruction benchmarking.

Most importantly this addresses the SMO changes from
FuelLabs/fuel-vm#407 and
FuelLabs/fuel-vm#404, and ALOC/HP changes from
FuelLabs/fuel-vm#377

---------

Co-authored-by: Tom <tomrgowan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dentosal Dentosal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update fuel-vm to 0.31 for gas benchmarks FuelLabs/fuel-core
1 participant
@Dentosal