Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make SMO instruction take data ptr as an argument #404

Merged
merged 4 commits into from
Mar 22, 2023
Merged

Make SMO instruction take data ptr as an argument #404

merged 4 commits into from
Mar 22, 2023

Conversation

Dentosal
Copy link
Member

Closes #396

@Dentosal Dentosal added breaking A breaking api change fuel-vm Related to the `fuel-vm` crate. labels Mar 21, 2023
@Dentosal Dentosal requested a review from a team March 21, 2023 13:04
@Dentosal Dentosal self-assigned this Mar 21, 2023
xgreenx
xgreenx reviewed Mar 21, 2023
View reviewed changes
fuel-vm/src/interpreter/blockchain.rs Outdated Show resolved Hide resolved
fuel-vm/src/tests/blockchain.rs
#[rustfmt::skip]
let script = vec![
op::movi(0x10, 2), // data buffer allocation size
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe with script_with_data_offset! we may do it more readable=D

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not script_data, instead I just allocate heap space for the bytes. Do you think I should rather use script_data for this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a script transaction, and we can pass as much data as we wish=) With script_with_data_offset!, we can use more than 2 bytes and pass them with fewer opcodes(it will be more readable than putting one byte into hp and another into hp + 1).

Plus, we can easy transform this test into rtest or test_case and make a test case with huge data, later=)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably shouldn't use script_with_data_offset anymore now that we have op::gtf to find the start of the script data.

@Dentosal Dentosal force-pushed the dento/change-smo-args branch 3 times, most recently from 0ce381e to e709723 Compare March 21, 2023 17:04
@Dentosal Dentosal requested a review from xgreenx March 21, 2023 18:21
xgreenx
xgreenx approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@xgreenx xgreenx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up to decide regarding script_with_data_offset!. The change already is good, thank you!=)

@Dentosal
Copy link
Member Author

I'm going with the current version. I'm going to do the SMO internal charging next, and then I'll improve the tests after that.

@Dentosal Dentosal added this pull request to the merge queue Mar 22, 2023
@Dentosal Dentosal merged commit d313654 into master Mar 22, 2023
@Dentosal Dentosal deleted the dento/change-smo-args branch March 22, 2023 09:18
@Dentosal Dentosal mentioned this pull request Apr 27, 2023
Merged
@xgreenx xgreenx mentioned this pull request Apr 27, 2023
Merged
xgreenx added a commit to FuelLabs/fuel-core that referenced this pull request Apr 27, 2023
@xgreenx
Release 0.18.0 (#1165)
19f12ea 
The change bumps the version to `0.18.0` and exposes
`sync_max_get_header` and `sync_max_get_txns` in the helm chart.

# Release 0.18.0

## Overview

A new release brings:
- Optimization for the execution based on the performance from beta 3
and on internal benchmarks. Improved metrics gathering.
- Stabilization and better test coverage of the `fuel-vm`. We removed
almost all unsafe code and added test cases for each opcode. Fixed some
edge cases with memory in the `fuel-vm`.
- Fully integrated Merkle trees and filled all malleable fields in the
transactions.
- Added retryable messages, removed redundant fields from it, and
updated the API to support a new commitment schema.

## What's Changed

### Breaking

- All unsafe functions were replaced with safe analog in the
`fuel-crypto` - FuelLabs/fuel-vm#346
- `$hp` holds the address of the last available byte in a heap, while
previously it was `$hp - 1` -
FuelLabs/fuel-vm#377
- Each variant in the `fuel_tx::Input` enum now has its own type -
FuelLabs/fuel-vm#364
- Message nonce is unified and now `Bytes32` everywhere -
FuelLabs/fuel-vm#394
- Removed the `message_id` field from all places -
FuelLabs/fuel-vm#397,
FuelLabs/fuel-vm#373,
- Unified the block height in all places with the introduction of a new
`BlockHeigh` - FuelLabs/fuel-vm#410
- Make SMO instruction take data ptr as an argument -
FuelLabs/fuel-vm#404
- Now the chain id affects the signature and predicate's owner and
should be passed into the `sign` function -
FuelLabs/fuel-vm#406
- Updated the `produce_blocks` endpoint to accept the start time and the
number of blocks. All new blocks will use the previous timestamp as a
base - #1059
- The `fuel-core` stores only unspent coins and messages, so all API
that previously returned spent coins is affected - Prune owned coin idx
when inputs are spent by @Voxelot in
#1055
- The message proof API has been changed to be compatible with a new
version - #1071
- The `fuel-core` now has retryable messages and coin messages.
Retryable messages can only be consumed during successful transaction
execution. The coin message acts as common coins. `resouces_to_spend`
API was replaced with `coins_to_spend` that returns a new `CoinType`
type. - #1067

## All changes
* adding fuel-core service monitor to helm chart by @rfuelsh in
#1037
* Adding specific app selector by @rfuelsh in
#1039
* use sticky sessions for GQL requests to sentries by @Voxelot in
#1042
* Add ingress service name to helm chart by @rfuelsh in
#1043
* Added test to verify the iteration over owned transactions by @xgreenx
in #1041
* Change sentry lb to use clusterIP by @Voxelot in
#1045
* Fixed Tempfile dependency by @ControlCplusControlV in
#1048
* Write contract code in raw by @freesig in
#994
* attempt to use buildjet runners by @Voxelot in
#1017
* Set tx pointer during block production by @Voxelot in
#1054
* Used `BASE_AMOUNT` for test with bob to pay for fee by @xgreenx in
#1057
* Prepare GraphQL Crate for extraction by @ControlCplusControlV in
#1012
* Support large contract deployments over p2p by @Voxelot in
#1062
* fix yaml and add linting job by @Voxelot in
#1063
* Actualized the ABI for message to be compatible with last version of
the Solidity contracts. by @xgreenx in
#1060
* feat: Contract state and assets merkle data storage by @bvrooman in
#1008
* Take into account the previous block timestamp during block production
by @xgreenx in #1059
* Prune owned coin idx when inputs are spent by @Voxelot in
#1055
* Retrayable messages fuel-core part by @xgreenx in
#1067
* chore: Additional Tests for Contract States and Balances by @bvrooman
in #1073
* Rust 1.68.1 & Sparse Registry by @Voxelot in
#1077
* Nginx tuneup by @Voxelot in
#1080
* chore: Update balance and state Merkleization by @bvrooman in
#1084
* Support sticky session in the client by @xgreenx in
#1079
* Added e2e test to run 1000 `dry_run` by @xgreenx in
#1091
* Use docker.io auth credentials to overcome rate limiting by @Voxelot
in #1092
* honeycomb tracing subscription by @Voxelot in
#1083
* Update withdrawal proof API to support proving from a block header
committed to L1 by @xgreenx in
#1071
* Upstream v0.17.8 by @Voxelot in
#1102
* use chainid for transactions and predicates by @Voxelot in
#1107
* fix the dry-run e2e test to actually perform dry runs by @Voxelot in
#1111
* peer reputation with separate app & gossipsub score by @leviathanbeak
in #1028
* Adding sentry data synchronization by @rfuelsh in
#1115
* Capture metrics for graphql api by @Voxelot in
#1113
* Update cargo audit and add to commit by @freesig in
#1152
* add task params by @leviathanbeak in
#1159
* Took into account that block creation could take some time by @xgreenx
in #1162
* Applying optimizations from `0.17.11` release by @xgreenx in
#1158


**Full Changelog**:
v0.17.3...v0.18.0
Dentosal added a commit to FuelLabs/fuel-core that referenced this pull request Apr 28, 2023
@Dentosal @freesig
Update fuel-vm to 0.31 for gas benchmarks (#1166)
75697b3 
Fixes #1164. Prepares for wide math intstruction benchmarking.

Most importantly this addresses the SMO changes from
FuelLabs/fuel-vm#407 and
FuelLabs/fuel-vm#404, and ALOC/HP changes from
FuelLabs/fuel-vm#377

---------

Co-authored-by: Tom <tomrgowan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voxelot Voxelot Voxelot approved these changes

@xgreenx xgreenx xgreenx approved these changes

Assignees

@Dentosal Dentosal

Labels
breaking A breaking api change fuel-vm Related to the `fuel-vm` crate.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make smo use rb for msg data ptr and rc for data len
3 participants
@Dentosal @Voxelot @xgreenx