Reused CheckedTransaction from transaction pool in the executor
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
Jul 14, 2023
crates/fuel-core/src/executor.rs
Outdated
| } | ||
|
|
||
| let block_height = *header.height(); | ||
| match tx { |
There was a problem hiding this comment.
Maybe we should try to reduce some of the duplication in these match arms?
For example, we could first turn a MaybeCheckedTransaction into a CheckedTransaction, and then separately execute the normalized CheckedTransaction.
Voxelot
previously approved these changes
Jul 14, 2023
Voxelot
approved these changes
Jul 14, 2023
Merged
xgreenx
added a commit
that referenced
this pull request
Jul 17, 2023
## Release v0.20.0 The release brings a couple of new breaking changes from the [`fuel-vm 0.35.0`](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.35.0) with bugfixes. Check the description of the VM release for more details. The `fuel-core` release mostly improved the internal codebase but also brought some breaking changes: - Removed `Trigger::Hybrid` PoA block trigger mode. Only `Trigger::Instante` and `Trigger::Interval` are available for block production now. The main mode for testnets and mainnet will be `Interval`. - Removed support for `OpaqueReceipt` and the `Receipt` type doesn't have the `raw_payload` field anymore. - A `Receipt` type got two new variants: `Mint` and `Burn`. The corresponding opcodes emit these new events. - The `AssetId` is derived from `ContractId` and additional nonce. So the `ContractId` and `AssetId` can't be the same anymore. ## What's Changed * bump rocksdb to enable compiling with GCC 13 by @segfault-magnet in #1219 * setting peer reputation params by @leviathanbeak in #1202 * Take into account the actually used gas by the transactions and fetch more transaction by @xgreenx in #1223 * Use production configuration for `fuel-core` during benches by @xgreenx in #1227 * Speedup and stabilize unit and integration tests by @xgreenx in #1231 * test: State benchmarks by @bvrooman in #1226 * Remove hybrid PoA block trigger mode by @Dentosal in #1232 * test: Benchmark contract state insertions with DB vs. DB transactions by @bvrooman in #1230 * multiplatform docker builds by @Voxelot in #1233 * Fix typo in architecture.md by @eltociear in #1241 * Expose gas cost in chain info by @MitchTurner in #1244 * Reuse calculated tx id in executor by @MitchTurner in #1248 * Fix multi-platform images by @Voxelot in #1251 * Add logging of the long GraphQL queries for future debug by @MitchTurner in #1250 * Reused `CheckedTransaction` from transaction pool in the executor by @xgreenx in #1249 * Bump `fuel-vm` to `0.35.0` version by @xgreenx in #1256 ## New Contributors * @segfault-magnet made their first contribution in #1219 * @eltociear made their first contribution in #1241 * @MitchTurner made their first contribution in #1244 **Full Changelog**: v0.19.1...v0.20.0
goldenpath1109
added a commit
to goldenpath1109/fuel-core
that referenced
this pull request
Sep 7, 2024
## Release v0.20.0 The release brings a couple of new breaking changes from the [`fuel-vm 0.35.0`](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.35.0) with bugfixes. Check the description of the VM release for more details. The `fuel-core` release mostly improved the internal codebase but also brought some breaking changes: - Removed `Trigger::Hybrid` PoA block trigger mode. Only `Trigger::Instante` and `Trigger::Interval` are available for block production now. The main mode for testnets and mainnet will be `Interval`. - Removed support for `OpaqueReceipt` and the `Receipt` type doesn't have the `raw_payload` field anymore. - A `Receipt` type got two new variants: `Mint` and `Burn`. The corresponding opcodes emit these new events. - The `AssetId` is derived from `ContractId` and additional nonce. So the `ContractId` and `AssetId` can't be the same anymore. ## What's Changed * bump rocksdb to enable compiling with GCC 13 by @segfault-magnet in FuelLabs/fuel-core#1219 * setting peer reputation params by @leviathanbeak in FuelLabs/fuel-core#1202 * Take into account the actually used gas by the transactions and fetch more transaction by @xgreenx in FuelLabs/fuel-core#1223 * Use production configuration for `fuel-core` during benches by @xgreenx in FuelLabs/fuel-core#1227 * Speedup and stabilize unit and integration tests by @xgreenx in FuelLabs/fuel-core#1231 * test: State benchmarks by @bvrooman in FuelLabs/fuel-core#1226 * Remove hybrid PoA block trigger mode by @Dentosal in FuelLabs/fuel-core#1232 * test: Benchmark contract state insertions with DB vs. DB transactions by @bvrooman in FuelLabs/fuel-core#1230 * multiplatform docker builds by @Voxelot in FuelLabs/fuel-core#1233 * Fix typo in architecture.md by @eltociear in FuelLabs/fuel-core#1241 * Expose gas cost in chain info by @MitchTurner in FuelLabs/fuel-core#1244 * Reuse calculated tx id in executor by @MitchTurner in FuelLabs/fuel-core#1248 * Fix multi-platform images by @Voxelot in FuelLabs/fuel-core#1251 * Add logging of the long GraphQL queries for future debug by @MitchTurner in FuelLabs/fuel-core#1250 * Reused `CheckedTransaction` from transaction pool in the executor by @xgreenx in FuelLabs/fuel-core#1249 * Bump `fuel-vm` to `0.35.0` version by @xgreenx in FuelLabs/fuel-core#1256 ## New Contributors * @segfault-magnet made their first contribution in FuelLabs/fuel-core#1219 * @eltociear made their first contribution in FuelLabs/fuel-core#1241 * @MitchTurner made their first contribution in FuelLabs/fuel-core#1244 **Full Changelog**: FuelLabs/fuel-core@v0.19.1...v0.20.0
crypto523
added a commit
to crypto523/fuel-core
that referenced
this pull request
Oct 7, 2024
## Release v0.20.0 The release brings a couple of new breaking changes from the [`fuel-vm 0.35.0`](https://github.com/FuelLabs/fuel-vm/releases/tag/v0.35.0) with bugfixes. Check the description of the VM release for more details. The `fuel-core` release mostly improved the internal codebase but also brought some breaking changes: - Removed `Trigger::Hybrid` PoA block trigger mode. Only `Trigger::Instante` and `Trigger::Interval` are available for block production now. The main mode for testnets and mainnet will be `Interval`. - Removed support for `OpaqueReceipt` and the `Receipt` type doesn't have the `raw_payload` field anymore. - A `Receipt` type got two new variants: `Mint` and `Burn`. The corresponding opcodes emit these new events. - The `AssetId` is derived from `ContractId` and additional nonce. So the `ContractId` and `AssetId` can't be the same anymore. ## What's Changed * bump rocksdb to enable compiling with GCC 13 by @segfault-magnet in FuelLabs/fuel-core#1219 * setting peer reputation params by @leviathanbeak in FuelLabs/fuel-core#1202 * Take into account the actually used gas by the transactions and fetch more transaction by @xgreenx in FuelLabs/fuel-core#1223 * Use production configuration for `fuel-core` during benches by @xgreenx in FuelLabs/fuel-core#1227 * Speedup and stabilize unit and integration tests by @xgreenx in FuelLabs/fuel-core#1231 * test: State benchmarks by @bvrooman in FuelLabs/fuel-core#1226 * Remove hybrid PoA block trigger mode by @Dentosal in FuelLabs/fuel-core#1232 * test: Benchmark contract state insertions with DB vs. DB transactions by @bvrooman in FuelLabs/fuel-core#1230 * multiplatform docker builds by @Voxelot in FuelLabs/fuel-core#1233 * Fix typo in architecture.md by @eltociear in FuelLabs/fuel-core#1241 * Expose gas cost in chain info by @MitchTurner in FuelLabs/fuel-core#1244 * Reuse calculated tx id in executor by @MitchTurner in FuelLabs/fuel-core#1248 * Fix multi-platform images by @Voxelot in FuelLabs/fuel-core#1251 * Add logging of the long GraphQL queries for future debug by @MitchTurner in FuelLabs/fuel-core#1250 * Reused `CheckedTransaction` from transaction pool in the executor by @xgreenx in FuelLabs/fuel-core#1249 * Bump `fuel-vm` to `0.35.0` version by @xgreenx in FuelLabs/fuel-core#1256 ## New Contributors * @segfault-magnet made their first contribution in FuelLabs/fuel-core#1219 * @eltociear made their first contribution in FuelLabs/fuel-core#1241 * @MitchTurner made their first contribution in FuelLabs/fuel-core#1244 **Full Changelog**: FuelLabs/fuel-core@v0.19.1...v0.20.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds a
MaybeCheckedTransactiontype that is eitherCheckedTransactionorTransaction.We need it because the validation of the block works with the
Transactiontype, while block production works withCheckedTransaction(TxPool has already validated transactions before during insertion).The executor calls
check_signaturesandcheck_predicatesthat inside only will be executed if the flag is not set.It should speedup block production