feat: Add receipts to transaction status #1504
Conversation
crates/fuel-core/src/executor.rs
Outdated
| @@ -1699,6 +1699,7 @@ where | |||
| db.update_tx_status( | |||
| id, | |||
| TransactionStatus::Success { | |||
| tx_id: *id, | |||
There was a problem hiding this comment.
We don't need to store tx_id in the database because we can fetch it from the key. The GraphQL type may have this field, while the type that we use across fuel-core does not.
bvrooman
changed the title
crates/client/src/client.rs
Outdated
| // TODO: Remove `receipts` now that receipts are queryable from the `Success` or `Failure` status | ||
| let receipts = self.receipts(&tx_id).await?; |
There was a problem hiding this comment.
You can remove it in this PR=)
There was a problem hiding this comment.
I removed this query and replaced it with a block to read the receipts from the transaction status retrieved earlier in this function. This introduces an extra clone() because we now duplicate the receipts. This is okay for now - in the future, we can remove this function entirely because it is now redundant, and the submit_and_await_commit endpoint will return receipts for all successful and failed transactions. I have added a TODO inline to highlight this.
| impl From<(TxId, TxStatus)> for TransactionStatus { | ||
| fn from((tx_id, s): (TxId, TxStatus)) -> Self { |
There was a problem hiding this comment.
Hmm, you can fetch tx_id from the query. You don't need to join them together from different sources
There was a problem hiding this comment.
As discussed over a call: This TransactionStatus is part of fuel-core, and the TxId is being correctly retrieved from the query. I have replaced the implementation of From on this tuple with a constructor for more clarity.
## Version v0.22.0 ### Added - [#1515](#1515): Added support of `--version` command for `fuel-core-keygen` binary. - [#1504](#1504): A `Success` or `Failure` variant of `TransactionStatus` returned by a query now contains the associated receipts generated by transaction execution. #### Breaking - [#1531](#1531): Make `fuel-core-executor` `no_std` compatible. It affects the `fuel-core` crate because it uses the `fuel-core-executor` crate. The change is breaking because of moved types. - [#1524](#1524): Adds information about connected peers to the GQL API. ### Changed - [#1517](#1517): Changed default gossip heartbeat interval to 500ms. - [#1520](#1520): Extract `executor` into `fuel-core-executor` crate. ### Fixed #### Breaking - [#1536](#1536): The change fixes the contracts tables to not touch SMT nodes of foreign contracts. Before, it was possible to invalidate the SMT from another contract. It is a breaking change and requires re-calculating the whole state from the beginning with new SMT roots. ## What's Changed * Added support of `--version` command for `fuel-core-keygen` binary by @xgreenx in #1515 * Weekly `cargo update` by @github-actions in #1518 * feat: Add receipts to transaction status by @bvrooman in #1504 * chore: Update gossip heartbeat interval by @bvrooman in #1517 * Weekly `cargo update` by @github-actions in #1525 * Run beta 4 e2e test each 30 minutes by @xgreenx in #1528 * Fix broken link. by @lukema95 in #1526 * Extract executor into fuel-core-executor crate by @Salka1988 in #1520 * Weekly `cargo update` by @github-actions in #1534 * Make `fuel-core-executor` `no_std` compatible by @Salka1988 in #1532 * Fixed contracts tables to touch only own SMT nodes by @xgreenx in #1536 * Show info about connected peers in the gql api by @Voxelot in #1524 * fix committed gql schema by @Voxelot in #1540 ## New Contributors * @lukema95 made their first contribution in #1526 **Full Changelog**: v0.21.0...v0.22.0
Related issues:
This PR adds receipts to the transaction status objects returned by transaction-related GraphQL queries. When querying for the status of a transaction, a status of
FailedorSuccesswill now include the transaction receipts.Note that this PR does not remove Receipts from
OpaqueTransactionor other places that would constitute a breaking change, thus preserving existing behaviour. We can remove receipts from redundant areas in a follow up PR after the beta release.