Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract executor into fuel-core-executor crate #1520

Merged
merged 39 commits into from
Dec 4, 2023

Conversation

Salka1988
Copy link
Member

@Salka1988 Salka1988 commented Nov 27, 2023

This PR moves the existing executor module into this separate crate.

@Salka1988 Salka1988 self-assigned this Nov 27, 2023
@Salka1988 Salka1988 linked an issue Nov 27, 2023 that may be closed by this pull request
Salka1988 and others added 10 commits November 29, 2023 18:39
# Conflicts:
#	Cargo.lock
#	benches/Cargo.toml
#	benches/src/lib.rs
#	crates/database/src/vm_database.rs
#	crates/fuel-core/Cargo.toml
#	crates/fuel-core/src/database.rs
#	crates/fuel-core/src/executor.rs
crates/storage/src/database.rs Outdated Show resolved Hide resolved
crates/storage/src/database.rs Outdated Show resolved Hide resolved
crates/storage/src/database.rs Outdated Show resolved Hide resolved
crates/storage/src/database.rs Outdated Show resolved Hide resolved
crates/storage/src/database.rs Outdated Show resolved Hide resolved
crates/database/src/vm_database.rs Outdated Show resolved Hide resolved
crates/storage/Cargo.toml Outdated Show resolved Hide resolved
crates/services/executor/src/refs/database.rs Outdated Show resolved Hide resolved
crates/services/executor/src/lib.rs Outdated Show resolved Hide resolved
@Salka1988 Salka1988 changed the title Salka1988/extract executor Extract executor into fuel-core-executor crate Dec 1, 2023
@Salka1988 Salka1988 marked this pull request as ready for review December 1, 2023 16:13
Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for colossal work!=)

Could you create an issue to move unit tests to fuel-core-executor, please?=)

@xgreenx xgreenx requested a review from a team December 4, 2023 11:44
@Salka1988
Copy link
Member Author

Salka1988 commented Dec 4, 2023

Thank you for colossal work!=)

Could you create an issue to move unit tests to fuel-core-executor, please?=)

Thank you for your availability and valuable advices. I'll make the issue.

@@ -9,6 +9,7 @@
#![deny(missing_docs)]
#![deny(unused_crate_dependencies)]
#![deny(warnings)]
#![deny(unused_variables)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: isn't this implied by #![deny(warnings)]?

@xgreenx xgreenx merged commit d88b7f4 into master Dec 4, 2023
30 checks passed
@xgreenx xgreenx deleted the Salka1988/extract_executor branch December 4, 2023 17:57
@xgreenx xgreenx mentioned this pull request Dec 12, 2023
xgreenx added a commit that referenced this pull request Dec 12, 2023
## Version v0.22.0

### Added

- [#1515](#1515): Added
support of `--version` command for `fuel-core-keygen` binary.
- [#1504](#1504): A `Success`
or `Failure` variant of `TransactionStatus` returned by a query now
contains the associated receipts generated by transaction execution.

#### Breaking
- [#1531](#1531): Make
`fuel-core-executor` `no_std` compatible. It affects the `fuel-core`
crate because it uses the `fuel-core-executor` crate. The change is
breaking because of moved types.
- [#1524](#1524): Adds
information about connected peers to the GQL API.

### Changed

- [#1517](#1517): Changed
default gossip heartbeat interval to 500ms.
- [#1520](#1520): Extract
`executor` into `fuel-core-executor` crate.

### Fixed

#### Breaking
- [#1536](#1536): The change
fixes the contracts tables to not touch SMT nodes of foreign contracts.
Before, it was possible to invalidate the SMT from another contract. It
is a breaking change and requires re-calculating the whole state from
the beginning with new SMT roots.

## What's Changed
* Added support of `--version` command for `fuel-core-keygen` binary by
@xgreenx in #1515
* Weekly `cargo update` by @github-actions in
#1518
* feat: Add receipts to transaction status by @bvrooman in
#1504
* chore: Update gossip heartbeat interval by @bvrooman in
#1517
* Weekly `cargo update` by @github-actions in
#1525
* Run beta 4 e2e test each 30 minutes by @xgreenx in
#1528
* Fix broken link. by @lukema95 in
#1526
* Extract executor into fuel-core-executor crate by @Salka1988 in
#1520
* Weekly `cargo update` by @github-actions in
#1534
* Make `fuel-core-executor` `no_std` compatible by @Salka1988 in
#1532
* Fixed contracts tables to touch only own SMT nodes by @xgreenx in
#1536
* Show info about connected peers in the gql api by @Voxelot in
#1524
* fix committed gql schema by @Voxelot in
#1540

## New Contributors
* @lukema95 made their first contribution in
#1526

**Full Changelog**:
v0.21.0...v0.22.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract executor into fuel-core-executor crate
3 participants