Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: dry run doesn't work for Create #737

Merged
merged 3 commits into from
Oct 29, 2022
Merged

Bugfix: dry run doesn't work for Create #737

merged 3 commits into from
Oct 29, 2022

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Oct 28, 2022

We don't generate receipts for Create transactions, so "Expected at least one set of receipts" is relevant only for Script.

@xgreenx xgreenx added the bug Something isn't working label Oct 28, 2022
@xgreenx xgreenx requested a review from a team October 28, 2022 15:47
@xgreenx xgreenx self-assigned this Oct 28, 2022
@xgreenx xgreenx mentioned this pull request Oct 28, 2022
Merged
Dentosal
Dentosal approved these changes Oct 28, 2022
View reviewed changes
Copy link
Member

@Dentosal Dentosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xgreenx xgreenx merged commit d5b359e into master Oct 29, 2022
@xgreenx xgreenx deleted the bugfix/dry-run-for-create branch October 29, 2022 01:16
@luizstacio luizstacio mentioned this pull request Oct 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voxelot Voxelot Voxelot approved these changes

@Dentosal Dentosal Dentosal approved these changes

Assignees

@xgreenx xgreenx

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xgreenx @Voxelot @Dentosal