feat: update fuel-core v0.13 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsjams
suggested changes
Oct 31, 2022
camsjams
reviewed
Oct 31, 2022
camsjams
suggested changes
Oct 31, 2022
Coverage report
Show new covered files 🐣
Test suite run success543 tests passing in 49 suites. Report generated by 🧪jest coverage report action from 0ffdab9 |
added 3 commits
November 1, 2022 23:42
|
@luizstacio Seems like all blockers for this are gone (the Rust SDK already supports core 0.13). Let me know if you need help with this, you can also check FuelLabs/fuels-rs#657 for some reference. |
Yes I've taken over this PR, I have it down to 6 failing unit tests related to Storage, seems like values have changed so need to see what has to be updated. |
Sweet! As I said, the rust SDK PR I linked above has all the changes needed if you wanna take a peek. |
arboleya
requested changes
Nov 3, 2022
QuinnLee
previously approved these changes
Nov 3, 2022
camsjams
approved these changes
Nov 3, 2022
QuinnLee
approved these changes
Nov 3, 2022
arboleya
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update fuels-ts to work with fuel-core v0.13.
On this PR, I had to update message handling. The previous implementation led to errors in the message Id calculation, it would be great to get a deeper look from @camsjams. Looking at the specs, it looks like message data should be encoded and decoded in the same way predicateData is.
On the sway side, we have a blocker related to storage persistency, as the latest is not yet compatible with fuel-core v0.13.
Blockers;
FuelLabs/sway#3181
FuelLabs/fuel-core#737