Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new fuel-vm version #917

Merged
merged 7 commits into from
Jan 24, 2023
Merged

Update to new fuel-vm version #917

merged 7 commits into from
Jan 24, 2023

Conversation

Dentosal
Copy link
Member

@Dentosal Dentosal commented Jan 19, 2023

Includes breaking changes from FuelLabs/fuel-vm#307. Requires FuelLabs/fuel-vm#314 as well.

@xgreenx
Copy link
Collaborator

xgreenx commented Jan 19, 2023

Hmm, it looks like it almost duplicates the #806. Maybe it is better to use Tommi's PR as a base for your PR to include FuelLabs/fuel-vm#307

@Dentosal
Copy link
Member Author

I totally missed that PR, it indeed seems to have lots of duplicate changes. I'm going to wait until it's merged and rebase this on top of it after.

Dentosal and others added 3 commits January 24, 2023 16:47
Adapted implementation of the `StorageInspect` and `StorageMutate` to use a new `Mappable`.
Used a new double storage key instead of tuples.
`empty_sum` is private now=( Repalced with `empty_sum_sha256`. Will create a patch for `fuel-merkle`.
@Voxelot Voxelot marked this pull request as ready for review January 24, 2023 18:42
Voxelot
Voxelot previously approved these changes Jan 24, 2023
@xgreenx xgreenx self-assigned this Jan 24, 2023
@xgreenx xgreenx requested a review from a team January 24, 2023 18:53

#[test]
fn get() {
let balance_id: (ContractId, AssetId) =
(ContractId::from([1u8; 32]), AssetId::new([1u8; 32]));
let key = (&ContractId::from([1u8; 32]), &AssetId::new([1u8; 32])).into();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants