You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I didn't see any deposit and withdraw types in our tx format as of today.
With v1.x we have clearly specified withdraw and deposit types. I recommend adding these for our tx format, keeping them the same as before unless further changes are required.
Posterity:
I would keep the same properties for deposit, namely the block number, amount, token and receiver.
Note:
Funnels can come later if choose to continue that pattern.
The text was updated successfully, but these errors were encountered:
adlerjohn
changed the title
Withdraw and Deposit Tx Types
Add withdrawal output type
Feb 21, 2021
keeping them the same as before unless further changes are required
I disagree. There's no benefit to restricting ourselves to anything in the v1.x design, which was made ad-hoc without fully planning things out. The smart contracts will be re-written and changing the deposit format is trivial in a properly-abstracted codebase.
I would keep the same properties for deposit, namely the block number, amount, token and receiver.
Motivation:
I didn't see any deposit and withdraw types in our tx format as of today.
With v1.x we have clearly specified withdraw and deposit types. I recommend adding these for our tx format, keeping them the same as before unless further changes are required.
Posterity:
I would keep the same properties for deposit, namely the block number, amount, token and receiver.
Note:
Funnels can come later if choose to continue that pattern.
The text was updated successfully, but these errors were encountered: