Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dynamic supported fuel-core version in version check #1189

Closed
1 task done
Br1ght0ne opened this issue Nov 7, 2023 · 0 comments · Fixed by #1190
Closed
1 task done

Use dynamic supported fuel-core version in version check #1189

Br1ght0ne opened this issue Nov 7, 2023 · 0 comments · Fixed by #1190
Assignees
@Br1ght0ne
Labels
blocked fuel-core Requires more info or is blocked by fuel-core

Comments

@Br1ght0ne
Copy link
Member

Br1ght0ne commented Nov 7, 2023 •
edited
Loading

#1166 should be extended by using actual fuel-core version from Cargo.toml.
@Br1ght0ne Br1ght0ne self-assigned this Nov 7, 2023
@Br1ght0ne Br1ght0ne mentioned this issue Nov 7, 2023
Merged
xgreenx pushed a commit to FuelLabs/fuel-core that referenced this issue Nov 7, 2023
@Br1ght0ne
Expose fuel-core version as a constant (#1473)
dc15f7f 
Necessary for FuelLabs/fuels-rs#1189. This
allows `fuels-rs` to make compatibility checks against the version of
`fuel-core` it was compiled with.
@Br1ght0ne Br1ght0ne mentioned this issue Nov 7, 2023
Merged
6 tasks
@Br1ght0ne Br1ght0ne added blocked fuel-core Requires more info or is blocked by fuel-core labels Nov 20, 2023
Br1ght0ne added a commit that referenced this issue May 22, 2024
@Br1ght0ne @segfault-magnet
Use dynamic supported fuel-core version (#1190)
b706076 
Close #1189. ~~Waiting on a
new `fuel-core` release incorporating
FuelLabs/fuel-core#1473

### Checklist
- [x] I have linked to any relevant issues.
- [ ] I have updated the documentation.
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [x] I have added necessary labels.
- [x] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [x] I have requested a review from the relevant team or maintainers.

---------

Co-authored-by: Ahmed Sagdati <37515857+segfault-magnet@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Br1ght0ne Br1ght0ne

Labels
blocked fuel-core Requires more info or is blocked by fuel-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use dynamic supported fuel-core version FuelLabs/fuels-rs
1 participant
@Br1ght0ne