Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log/error on mismatch of client version and supported version #1166

Merged
merged 7 commits into from
Oct 16, 2023
Merged

feat: log/error on mismatch of client version and supported version #1166

merged 7 commits into from
Oct 16, 2023

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Oct 12, 2023 •
edited
Loading

Close #1138. Shamelessly ported from fuels-ts's FuelLabs/fuels-ts#1287.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Br1ght0ne Br1ght0ne added enhancement New feature or request dev-experience labels Oct 12, 2023
@Br1ght0ne Br1ght0ne self-assigned this Oct 12, 2023
@Br1ght0ne Br1ght0ne marked this pull request as ready for review October 12, 2023 18:51
hal3e
hal3e requested changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just have a request regarding visibility

packages/fuels-accounts/src/lib.rs Outdated Show resolved Hide resolved
packages/fuels-accounts/src/supported_versions.rs Outdated Show resolved Hide resolved
packages/fuels-accounts/src/supported_versions.rs Outdated Show resolved Hide resolved
packages/fuels-accounts/src/supported_versions.rs Outdated Show resolved Hide resolved
@Br1ght0ne @hal3e
Apply suggestions from code review
a274fbe 
Co-authored-by: hal3e <git@hal3e.io>
@Br1ght0ne Br1ght0ne requested a review from hal3e October 13, 2023 12:10
iqdecay
iqdecay previously approved these changes Oct 13, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, very elegant and quick solution!

@Br1ght0ne @MujkicA
refactor: move clone() closer to API edge
b436f50 
Co-authored-by: Ahmed Mujkic <32431923+MujkicA@users.noreply.github.com>
MujkicA
MujkicA approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@MujkicA MujkicA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Br1ght0ne Br1ght0ne enabled auto-merge (squash) October 16, 2023 14:16
hal3e
hal3e approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@hal3e hal3e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Br1ght0ne Br1ght0ne merged commit f12ff73 into master Oct 16, 2023
39 checks passed
@Br1ght0ne Br1ght0ne deleted the oleksii/client-version-check branch October 16, 2023 15:27
@Br1ght0ne Br1ght0ne mentioned this pull request Nov 7, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MujkicA MujkicA MujkicA approved these changes

@iqdecay iqdecay iqdecay approved these changes

@hal3e hal3e hal3e approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@Br1ght0ne Br1ght0ne

Labels
dev-experience enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check the provider's version and throw an error (warning?) if the version is old and unsupported
4 participants
@Br1ght0ne @MujkicA @iqdecay @hal3e