-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use dynamic supported fuel-core version #1190
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this hasn't been your focus lately, but is there any updates on this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some notes:
- Using a
build.rs
is problematic because this will cause our users to always depend onfuel-core
since we're packaging abuild.rs
dependent onfuel-core
that will run when users build their software. One of the motivations for thefuel-core-lib
is to lower compile times for live demos. - We need a CI check that when the fuel-core version in the workspace cargo toml is updated the corresponding version file matches the version in the toml.
- If we're to generate version files we might as well generate a rust file that has a
pub const version: ... = VERSION_HERE
. Better yet if there is aconst
version structure so that we don't have to do any parsing in runtime.
Maybe it is enough to have that version.rs
file with a unpublished binary that checks if the versions match. Something like the docs checker binary currently run in the CI.
Also keep in mind that sometimes our fuel-core
versions are git checkouts, when there are circularly dependent breaking changes between the compiler, core and us. The CI should allow for this (unless we're publishing).
0ccc474
to
125f3ac
Compare
This reverts commit 8b667df.
108cba3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Close #1189.
Waiting on a newfuel-core
release incorporating FuelLabs/fuel-core#1473.Checklist