Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and questions from SwaySwap development #136

Closed
8 of 9 tasks
luizstacio opened this issue Feb 24, 2022 · 1 comment
Closed
8 of 9 tasks

Improvements and questions from SwaySwap development #136

luizstacio opened this issue Feb 24, 2022 · 1 comment

Comments

@luizstacio
Copy link
Member

luizstacio commented Feb 24, 2022

Improvements and questions

  • Transaction error returns are not detailed enough; We need to debug binaries, etc.
  • Transfer coins need to have a script id. It's possible to use a script already implemented on the Core; we
    have used the id 0x24400000 , but it would be nice to have some table with available scripts and what they do.
  • scriptData needs to have random data every time to make transactions different. known issue.
  • It's challenging to work with amounts; we should have something like https://docs.ethers.io/v5/api/utils/display-logic/#utils-parseUnits
  • Empty values were not parsed, resulting in type is not found on the ts SDK. fix!: Handle empty value in abi #134 should fix it.
  • Generate Contract factory with fuels dependency #183
    • The readme is not clear it should install the dependencies;
    • I had the dependency fuels on the project and had to install the specific dependencies or change manually on the generated file. Maybe we should check if the fuels is installed and use it or If it is not possible to check. We could use fuels as a preferable dependency.
  • We don't have a tutorial explaining how to do a full demo; we could use swayswap to create something like this.
@digorithm
Copy link
Member

About

Transfer coins need to have a script id. It's possible to use a script already implemented on the Core; we
have used the id 0x24400000 , but it would be nice to have some table with available scripts and what they do.

I just implemented it here: FuelLabs/fuels-rs#110. Maybe that could help you with this point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants