-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The historical view is not implemented for MemoryStore
#2857
Comments
launchTestNode
throwing the historical view is not implemented for MemoryStore
launchTestNode
throwing historical view is not implemented for MemoryStore
What is there to be fixed on the ts-sdk? |
@arboleya the error is being thrown here on random tests, so I've tried a very rudimentary way to suppress it in the tests since it's not relevant to our test cases, but I haven't investigated the issue in depth to see the root cause. |
Had a brief look and it appears to occur predominantly when we pass through a custom POA, however, this could be a red herring. |
Following @Torres-ssf investigations, I understood it's coming from If that is true, it may have nothing to do with |
Is this issue a |
@arboleya thanks for sharing that information, I'm still unsure how to reproduce the issue consistently. My primary rationale for raising this issue is that it's currently failing tests on #2811 and so I'll update the description according. At the very least we should handle the error / suppress it in test runs so it's not relevant to them. @petertonysmith94 I've been experiencing recurring failing tests on #2811 and for that reason I've made it a |
launchTestNode
throwing historical view is not implemented for MemoryStore
launchTestNode
when running tests
I've lowered this to a |
@maschad, I believe this error can be mitigated by using a longer I am under the impression that this error tends to occur when the The reasoning is that a shorter |
@Torres-ssf I'm aware that the issue is related to Unfortunately your recommendation is insufficient for this test use case (or any test similar to it) as it requires a transaction maturity > 1 and so we need a shorter interval period to increase block production time for such scenarios. |
I'm unassigning myself from this for now as it would require substantial engineering effort and currently only one test would benefit from it. We can revisit this in the future if needs be. |
launchTestNode
when running testsMemoryStore
Should be automatically solved when @maschad @Torres-ssf Please reopen if necessary. |
As we integrated
launchTestNode
across the whole monorepo, instances of the the errorappear more frequently in test runs, which affects the consistency of our tests. This is obviously due to the fact that we are using an in-memory database, but using a persistent key-value store comes with it's own challenges, and there aren't any test cases where we actually require historical data yet, so I wouldn't suggest that as a solution.
We should at the very least handle this error as it's not relevant to our test cases, so that we reduce flakiness in our CI checks.
Related to #2698
Related to #1755
The text was updated successfully, but these errors were encountered: