-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement typedoc in vitepress #1115
Conversation
Coverage report
Test suite run success1049 tests passing in 181 suites. Report generated by 🧪jest coverage report action from 7402047 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking beautiful.
I didn't review yet, just quickly glanced over it, here are some preliminary comments:
- Should we commit the generated MD files inside
src/api/classes
? Perhaps these could be generated only in CI before publishing. What do you think? - There seem to be a couple of annotations like this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Should we commit the generated MD files inside
src/api/classes
?
Another indication this may be optimal is that these files contain dynamic links such as:
Due to the blog part (bef034a9
), files will appear modified even when unchanged.
Other than that, everything is looking good! Very clean. 👌
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good at the surface level. How does this get updated (similar to what @arboleya mentioned)
Last time we used typedoc it updated alongside the changeset code, but with vitepress I think we can forego any git records right?
@danielbate Because you're already integrated fuels-ts/apps/docs/package.json Line 8 in bef034a
You just need to ignore these two dirs and voilà:
Everything else is already taken care of.
|
@arboleya If we are about to not commit the generated API files (which I believe is the way to go), we need to also make Typedoc to generate them on the |
@Torres-ssf Good point! @danielbate Maybe something like this would do the trick: "dev": "nodemon --config nodemon.config.json -x 'typedoc && vitepress dev'", |
…/feat/implement-api-docs
@Torres-ssf @arboleya Any reason they were included prior, as I can see they were removed when we moved to vitepress in #811? |
IIRC, @Torres-ssf changed the way we publish to GH pages, which made it possible. |
I'll pick up the new eslint warnings generated by the implementation of tsdoc in #1125 |
* feat: implement typedoc in docs * feat: add typedoc to address and interfaces * feat: generate typedoc docs * feat: implment typedoc in vitepress * feat: add api docs readme * chore: linting * chore: changeset * chore: update docs git ignore to exclude built docs * chore: remove api docs files * chore: update typedoc config * docs: update interface typedoc * feat: include typedoc in vitepress dev script * feat: reslove tsdoc linting warnings --------- Co-authored-by: danielbate <--global>
Following discussions in #835, this reimplements typedoc to provide API documentation to be housed by our current vitepress implementation by:
Address
andInterface
packages