Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve eslint warnings #1125

Merged
merged 26 commits into from
Jul 25, 2023
Merged

Conversation

danielbate
Copy link
Contributor

@danielbate danielbate commented Jul 25, 2023

Following #1115 to implement typedoc and thus tsdoc, eslint is now generating a few more warnings and we had a couple lingering from previous work. This PR will rectify those warning.

Screenshot 2023-07-25 at 09 47 21

@danielbate danielbate self-assigned this Jul 25, 2023
@danielbate
Copy link
Contributor Author

This will be converted from draft once #1115 has been merged

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements
83.56% (+0% 🔼)
4265/5104
🟡 Branches 62.71% 624/995
🟡 Functions 72.92% 727/997
🟢 Lines
83.7% (+0% 🔼)
4081/4876
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / index.ts
100% 100% 100% 100%

Test suite run success

1051 tests passing in 181 suites.

Report generated by 🧪jest coverage report action from ebac67e

Base automatically changed from db/feat/implement-api-docs to master July 25, 2023 14:28
@danielbate danielbate marked this pull request as ready for review July 25, 2023 14:31
@danielbate
Copy link
Contributor Author

@arboleya has resolved one of these since in #1080 however going to still request these changes as I prefer theskip() usage over commenting out the test.

@danielbate danielbate enabled auto-merge (squash) July 25, 2023 14:53
@danielbate danielbate merged commit 2ddc4a8 into master Jul 25, 2023
@danielbate danielbate deleted the db/chore/resolve-eslint-warnings branch July 25, 2023 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants