-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: switch docs engine #811
Conversation
Torres-ssf
commented
Mar 4, 2023
•
edited
Loading
edited
- Close docs: move from jekyll pages to a better doc engine #457
Coverage report
Test suite run success760 tests passing in 109 suites. Report generated by 🧪jest coverage report action from 1a0c0f1 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Some details about this PR:1- Vitepress search feature was designed to be used with Algolia. We can start using it for free, but I believe that at some point in the (not near) future, we will have to start paying fees (more details here). In order to start using Algolia we need to apply here. According to Algolia docs, anyone who can update the project content can apply, and no credit card is required. I haven't applied yet, I just want to make sure everyone is on the same page about it. But in the meantime, the search is working based on a workaround solution. 2 - The documentation build is now part of the project build process. Having said that, I am assuming we do not need to have a separate CI step to build the docs. I did some deploys tests on GitHub pages using a dummy repository, and realized that we only have 2 options during setup: deploys using GitHub Actions or pushing website files inside the 3 - We need to decide if we are going to continue generating the literal documentation of the code. If not, we won't need
|
|
Re. your previous comment @Torres-ssf, I will pretty much second what @arboleya said. Let's go with Algolia, and I feel like the general consensus is to move on from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there anyway you can re-commit everything to a new branch or force push with using a single commit for the docs guide files?
The doc files all got moved around but if they aren't DELETED and ADDED in same commit git can't detect a rename.
This makes it harder to see what changed so we'd all have to re-read ALL of the docs to determine if they are correct.
Also we lose all git history on their updates
db390b2
to
050aaef
Compare
Excellent, thanks for your update to the git history @Torres-ssf - it looks 👍 great! I will review again |
@Torres-ssf The |
ca3fe8c
to
f7fbad7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @Torres-ssf! Left some minor non-blocking comments.
@arboleya @Dhaiwat10 I Have worked on all requested changes and need the approval again 😅 |